Repository navigation
Conversation
Kshot3000
requested review from
IanoNjuguna,
Ranchhand87 and
danbaruka
as code owners
October 18, 2026 10:47
…IntersectMBO#337) - Delete website/yarn.lock and the stray root package-lock.json, leaving website/package-lock.json as the only tracked lockfile — the duplicate was why Dependabot double-counted the braces advisory (alerts 259/260) and reported node-forge from a lockfile CI never installs (alert 261). - Remove packageManager (yarn) and the yarn-only resolutions block from website/package.json; overrides already carries the identical 32 pins for npm (verified key-for-key), so nothing is lost. - Docs now describe npm only: website/README.md (npm install, npm run start:dev, npm run build; deployment section now points at the deploy workflow instead of manual yarn deploy to gh-pages), CONTRIBUTING.md (npm, npm run start:dev), and website/SECURITY.md (commit package.json + package-lock.json together). - Guard in pr-build-website.yml fails the PR build if any yarn.lock / pnpm-lock.yaml or a root package-lock.json is tracked again, and the workflow now also triggers on lockfile paths outside website/. Acceptance criteria for IntersectMBO#337: only website/package-lock.json tracked; no packageManager/resolutions; README + CONTRIBUTING npm-only; guard fails on a reintroduced lockfile (tested both ways locally). The Dependabot alert closure follows the post-merge scan.
Kshot3000
force-pushed
the
chore/standardise-npm
branch
from
October 18, 2026 10:48
cba7397 to
4e58a7d
Compare
Contributor
Author
Contributor
|
Hey Kyle, Going to review this before merging. |
Contributor
Author
|
Sounds good
…On Sun, Oct 18, 2026, 10:45 AM Ian Njuguna ***@***.***> wrote:
*IanoNjuguna* left a comment (IntersectMBO/developer-experience#365)
<#365 (comment)>
Hey Kyle, Going to review this before merging.
—
Reply to this email directly, view it on GitHub
<#365?email_source=notifications&email_token=CMAPYQEHLBRLGQNUR3VFFX35UTQQBA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMMRVGE4DIOJSG432M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6251849277>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/CMAPYQCL5JVWHY5JSMC3IPT5UTQQBAVCNFSNUABFKJSXA33TNF2G64TZHM4TANBYGUZDOOJWHNEXG43VMU5TKOJQHA3TCMBUGUYKC5QC>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #337 — standardises
website/on npm and deletes the duplicate lockfiles.What changed
website/yarn.lockand the stray rootpackage-lock.json(an emptypackages: {}lock with no matching manifest).website/package-lock.jsonis now the only tracked lockfile — the one CI actually installs from. This is the duplication that double-counted the braces advisory as alerts 259 + 260 and produced the false node-forge alert 261 from a lockfile CI never installs; both should close on the post-merge Dependabot scan.website/package.json: removed the"packageManager": "yarn@…"declaration and the yarn-onlyresolutionsblock. Nothing is lost: I verifiedresolutionsand the npmoverridesblock are identical — same 32 pins, key for key — before deleting.website/README.md—npm install,npm run start:dev(with a note thatnpm startis a full production build + serve, not the dev server),npm run build,npm run audit. The deployment section no longer tells contributors toyarn deploytogh-pagesby hand; it points at the deploy workflow that runs on push tomain.CONTRIBUTING.md— prerequisites are npm (not "npm or yarn"), and the local-server step isnpm run start:dev.website/SECURITY.md— one line in the same spirit: commitpackage.jsonandpackage-lock.jsontogether (it previously told contributors to commityarn.locktoo, which would reintroduce the duplicate).pr-build-website.ymlgains a step that fails the PR build if any trackedyarn.lock/pnpm-lock.yaml, or a rootpackage-lock.json, exists — and the workflow's path triggers now include lockfile paths outsidewebsite/**so a root-level lockfile PR runs the gate too.Verification
website/yarn.lockforce-added back → guard reports it (fail).website/package.jsonparses as valid JSON after the deletions; the diff is deletions-only there (35 lines).pr-build-websitecheck (npm ci+npm run buildfrom the surviving lockfile).Notes
CONTRIBUTING.md, in adjacent lines (mine: the package-manager prerequisite and the start command; chore: pin the Node version for contributors #342: the Node version line). If chore: pin the Node version for contributors #342 merges first, this branch may need a trivial rebase — happy to do it..agents/skills/harun-review/SKILL.md, which still describes yarn as the source of truth — that one reads like a maintainer-owned review skill, so flagging it here rather than rewriting it in this PR.Built as an independent Cardano community contributor — not affiliated with the Cardano Foundation, IOG or Intersect.
@Kshot9000 · https://x.com/kshot9000
ADA: addr1q8hnl6vl5a6k3rw3n5g3jtte696zcl76kfatzv7gpswa9r0dj7fma6klq55y4ffm7tf0em09udnyhuk4ah92pl5x9jpqjae44v
cc @cardano-foundation @IntersectMBO