Repository navigation
Conversation
IntersectMBO#323) The Feature component rendered <Link className="featureCardLinks"> as a plain string, but .featureCardLinks lives in styles.module.css, so the emitted class is hashed and the plain string never matches it. The module's .featureCardLinks:hover { text-decoration: none } rule was therefore dead and the cards showed the browser link underline on hover. Pass styles.featureCardLinks instead, like every other class in the component. Verified against production builds: before, build/index.html carries class="featureCardLinks" while the built CSS selector is .featureCardLinks_kdMv:hover (no match); after, the anchors carry class="featureCardLinks_kdMv", the same hash as the selector. docusaurus build and tsc --noEmit both pass.
Kshot3000
requested review from
IanoNjuguna,
Ranchhand87 and
danbaruka
as code owners
October 16, 2026 00:02
danbaruka
approved these changes
Oct 16, 2026
Author
|
Closing this as a duplicate — @IanoNjuguna's #332 landed the identical one-line fix ( Thanks for the review and approval, @danbaruka — happy to see #323 fixed either way. — Kyle Cox (@Kshot9000, https://x.com/kshot9000) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #323.
The three homepage feature cards are links, and on hover the browser underline showed through the title and description. The cause is exactly what the issue describes:
website/src/components/HomepageFeatures/index.tsxrendered<Link className="featureCardLinks" to={link}>— a plain string..featureCardLinks:hover { text-decoration: none; }, lives instyles.module.css, so it is emitted under a hashed class name and the plain string never matches it.Fix
One line: pass the CSS-module class, as every other class in this component already does:
The card lift and border styles are untouched.
Verification (production build, before / after)
Before, in
website/buildfrommain:build/index.html:<a class="featureCardLinks" href="/docs/working-group/">.featureCardLinks_kdMv:hover— a different name, so the rule could never apply.After this change:
build/index.html:<a class="featureCardLinks_kdMv" href="/docs/working-group/">— the same hash the built CSS selector uses, so the hover rule now matches.docusaurus buildsucceeds andtsc --noEmitis clean.One environment note: I installed with
npm ci --ignore-scripts --no-bin-linksand ran the build vianode node_modules/@docusaurus/core/bin/docusaurus.mjs build, skipping theprebuilddata fetch, sogithubData.jsonis unchanged in this PR.Independent builder — not affiliated with the Cardano Foundation, IOG or Intersect.
@Kshot9000 (https://x.com/kshot9000) · ADA donations: addr1q8hnl6vl5a6k3rw3n5g3jtte696zcl76kfatzv7gpswa9r0dj7fma6klq55y4ffm7tf0em09udnyhuk4ah92pl5x9jpqjae44v
cc @cardano-foundation @IntersectMBO