Repository navigation
Prepare for 2.4.0 release - #392
Merged
Merged
Conversation
vlad-perevezentsev
requested review from
antonwolfy,
jharlow-intel,
ndgrigorian and
xaleryb
as code owners
October 15, 2026 15:38
jharlow-intel
approved these changes
Oct 15, 2026
antonwolfy
reviewed
Oct 15, 2026
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
I checked the version bump and the final 2.4.0 changelog against the code merged in this cycle. The version bump looks good. My comments are inline, plus two on lines outside the diff:
- CHANGELOG.md:11 (Python 3.15): mkl-service has no cp315 wheel and no sdist on PyPI yet (2.8.0 ships cp310–cp314 only). So on 3.15,
pip install "mkl_fft[scipy_interface]"andpip install "mkl_fft[test]"fail to resolve. Both clang workflows already leave out 3.15 for this reason (see the TODO there). I'd add a short note about this to the entry. - CHANGELOG.md:27-28 (gh-364, gh-365): both only silence Coverity reports and change nothing at runtime. One declares
cdef int f_ndim, the other adds(void)statusfor anassertthat is compiled out under-DNDEBUG. Under "Fixed" they read as if 2.3.x had real bugs in_allocate_resultand__create_descriptor_1d. I'd drop them, same as the gh-374 entry.
antonwolfy
approved these changes
Oct 16, 2026
antonwolfy
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, the refined entries address my comments. The new wording matches the merged code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR updates
__version__andCHANGELOG.mdto publish the new 2.4.0 release