Repository navigation
Deprecate unused dpnp.config settings - #3107
Open
antonwolfy wants to merge 2 commits into
Open
antonwolfy wants to merge 2 commits into
antonwolfy wants to merge 2 commits into
Conversation
__DPNP_QUEUE_GPU__, __DPNP_OUTPUT_NUMPY__ and __DPNP_OUTPUT_DPCTL_DEFAULT_SHARED__ are not used anywhere in dpnp. Reading them now emits a DeprecationWarning; they will be removed in a future release.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
October 15, 2026 10:50
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3107/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev14=np2py314h8d9cdd5_6 ran successfully. |
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dpnp.configdefines__DPNP_QUEUE_GPU__,__DPNP_OUTPUT_NUMPY__and__DPNP_OUTPUT_DPCTL_DEFAULT_SHARED__, read from theDPNP_QUEUE_GPU,DPNP_OUTPUT_NUMPYandDPNP_OUTPUT_DPCTL_DEFAULT_SHAREDenvironment variables, but nothing in dpnp uses them, so setting those variables has no effect.This PR deprecates the three attributes before removing them: they are no longer module attributes but are served by a module-level
__getattr__, which returns the same value as before (still read from the environment at import) and emits aDeprecationWarning:Any other unknown name still raises
AttributeError. They can be removed in a future release by deleting_DEPRECATED_SETTINGSand__getattr__.__DPNP_ORIGIN__and__DPNP_RAISE_EXCEPION_ON_NUMPY_FALLBACK__are still used and are not changed. The test suite's own use of theDPNP_QUEUE_GPUenvironment variable, whichdpnp/tests/conftest.pyreads directly to pick the GPU skip list, is not affected.The new
dpnp/tests/test_config.pychecks that each deprecated attribute warns and returns its value, and that an unknown name raisesAttributeError. Importingdpnpemits no warning, and the warning points at the caller's line.