Repository navigation
Package the CuPy-based scipy tests - #3102
Open
antonwolfy wants to merge 3 commits into
Open
antonwolfy wants to merge 3 commits into
antonwolfy wants to merge 3 commits into
Conversation
The tests/third_party/cupyx/*/*.py glob reaches only the scipy_tests package itself, so the test files one level below it (linalg_tests, sparse_tests, special_tests) were left out of the dpnp package and never ran with --pyargs dpnp.tests against an installed package.
antonwolfy
requested review from
ndgrigorian and
vlad-perevezentsev
as code owners
October 14, 2026 19:31
Contributor
|
View rendered docs @ https://intelpython.github.io/dpnp/pull/3102/index.html |
Contributor
|
Array API standard conformance tests for dpnp=0.21.0dev14=np2py314h8d9cdd5_7 ran successfully. |
Collaborator
|
No base build to compare — fix-cupyx-tests-packaging into master |
At the test's density diag(a) is mostly zero, so 1/diag(a) put inf into the Jacobi preconditioner. SciPy and dpnp then both returned NaN, the comparison passed as NaN == NaN, and the reference side raised RuntimeWarnings. Use 1 for the zero diagonal entries so both sides compare finite results.
Without it the installed dpnp.tests.third_party was an implicit namespace package, unlike in the source tree.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
package_dataglobtests/third_party/cupyx/*/*.pyinsetup.pyreaches onlycupyx/scipy_tests/__init__.py, not the test files one level below it. Soscipy_tests/linalg_tests/test_decomp_lu.py,scipy_tests/sparse_tests/test_linalg.pyandscipy_tests/special_tests/test_erf.py(with their__init__.py) were left out of the dpnp package. The releaseddpnp-0.20.0wheel contains onlycupyx/__init__.pyandcupyx/scipy_tests/__init__.py.As a result these tests never ran in jobs that test an installed package with
--pyargs dpnp.tests, including the required condaTestjobs; they ran only in source-tree jobs (open-source LLVM SYCL build, coverage, oneMath). This PR adds thetests/third_party/cupyx/*/*/*.pyglob, after which every tracked file undercupyx/is covered.Locally the three test files pass on both the OpenCL CPU and the Level Zero GPU device (1745 passed, 385 skipped). They have not run on Windows before, so the Windows
Testjobs will be the first run there.