Repository navigation
build: pin NineToothed fused add RMSNorm - #609
Merged
Merged
Conversation
This was referenced Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fused_add_rms_norm#606 tomain.third_party/InfiniCorefrom2b4f2f20584a69b074f62a455e3de7368e3446c2toa6ba44fa568244c5dcc0f12b799f609483c06205.Motivation
#605 was merged into
mainas commitcc6d52ae04f4c9ff17229bc7fc13a9ad105aca6d. #606 was then accidentally merged into its old base branch,perf/initialize-ops-auto-tuning, rather than intomain.The resulting #606 merge commit is:
That commit contains the intended dependency pin, but it is not reachable from
main:The complete diff from current
mainto711054cis exactly one gitlink change:This PR therefore carries the reviewed #606 change to
mainwithout rewriting merged history. It also keeps #607 stacked on the intended dependency state.Closes N/A - replacement for the incorrectly targeted merge in #606.
Type of Change
feat— new feature / new modelfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changesTest Results of Involved Models on Supported Platforms (Please attach screenshots)
Validation inherited from the reviewed #606 change:
This replacement PR changes only the destination branch for the already reviewed gitlink; it does not alter the dependency content.
Benchmark / Performance Impact
N/A - manifest-only dependency update. The motivating provider benchmark remains:
FusedAddRmsNormindex 0Notes for Reviewers
fused_add_rms_norm#606 being merged into the wrong base branch.perf/initialize-ops-auto-tuning, because that branch already contains the reviewed build: pin NineToothedfused_add_rms_norm#606 result and is also the current base for perf: add NineToothed fused QK norm #607.mainshows only the intended one-line submodule revision change.main.CI / ChatOps
CI will be requested manually on head
711054ce05267ad80245222763cbda69b91e3fe9.Checklist
Title, Branch, and Commits
fused_add_rms_norm#606 was merged into the wrong base.main.fixup!/squash!/wipcommits remain.Scope and Design
General Code Hygiene
C++ Specific
Python Specific
Testing
Build, CI, and Tooling
Documentation
Security and Safety