Skip to content

Improve startup time on macOS #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danlamanna merged 2 commits into from
Oct 30, 2026
Merged

Improve startup time on macOS #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee42c7f
Build release binaries with a uv-managed Python
danlamanna Oct 30, 2026
2f48fb2
Build charset_normalizer from source for the PyInstaller bundle
danlamanna Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ jobs:
- name: Run packaging step
env:
UV_PYTHON: "3.12"
UV_PYTHON_PREFERENCE: only-managed
ISIC_CLI_SENTRY_DSN: ${{ secrets.ISIC_CLI_SENTRY_DSN }}
run: |
uv run tox -e package
Expand Down Expand Up @@ -71,6 +72,11 @@ jobs:
uv run tox -e package
env:
ISIC_CLI_SENTRY_DSN: ${{ secrets.ISIC_CLI_SENTRY_DSN }}
# the runners ship a python.org build of Python on PATH, which uv picks over downloading
# a managed one. python.org builds split the stdlib into ~50 separate extension modules,
# and on macOS every freshly extracted shared library costs ~120ms per launch of the
# onefile binary. python-build-standalone compiles them into libpython.
UV_PYTHON_PREFERENCE: only-managed
- name: Zip and upload binary
run: |
.github/zip_and_upload_package.sh ${{ runner.os }} ${{ github.event.release.tag_name }}
Expand Down
6 changes: 6 additions & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,12 @@ passenv =
ISIC_CLI_SENTRY_DSN
dependency_groups =
package
# charset_normalizer ships mypyc-compiled extensions with pure python fallbacks. on macOS, each
# shared library extracted by the onefile binary costs ~120ms per launch, so build it from source
# to get the pure python version instead.
uv_sync_flags =
--no-binary-package
charset-normalizer
commands =
python scripts/write_sentry_dsn_module.py {env_tmp_dir}/sentry_dsn/_isic_cli_sentry_dsn.py
pyinstaller \
Expand Down
Loading