Repository navigation
Copy component relations between distinct keys on the same entity - #59
Merged
HexDecimal merged 2 commits intoOct 14, 2026
Merged
HexDecimal merged 2 commits into
HexDecimal merged 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 9 9
Lines 956 956
=======================================
Hits 948 948
Misses 8 8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HexDecimal
force-pushed
the
fix/copy-between-component-relation-keys
branch
from
October 14, 2026 08:24
e232511 to
e88e94c
Compare
Owner
|
I've added the missing changelog note. Otherwise this has been another good fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning a component relation view to another key on the same entity silently returns without copying:
This currently prints
None; it should print5. The self-view shortcut checks the owner entity but ignores the component key. Require both to match before treating assignment as a no-op, then reuse the existing replacement path for different keys.Regression checks cover ordinary/named source keys, removing old destination targets, source preservation and an unchanged copy from another entity. On 36 native combat-effect map configurations, the change corrects 522 wrong target values and the corresponding 522 cached query results. All 18 different-owner controls and every source map remain exactly unchanged. The full pytest/doctest suite, mypy and project-pinned Ruff checks pass, retaining the same baseline xpasses and warning.
This changes only the self-view shortcut. It does not change copying depth, relation storage or the save format.