Repository navigation
Translate the knowledge graph, AI skills and memory pages (DE, IT) - #1360
Merged
Merged
Conversation
15 tasks done
Contributor
|
Thanks, this looks good. Strings only, links stay our own components, CI is green. Merging now. One small follow-up if you have time: the new "Code tool proposal" card from #1369 in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last area of #1271: the Knowledge Graph (
/knowledge-graph), AI Skills (/knowledge-graph/skills) and Memory (/memory) pages in German and Italian, with the folder tree they share. It follows #1340. No behaviour changes, andAccept-Language: en-USrenders exactly what it rendered before.Changes
app/knowledge-graph/page.tsx:components/kg-graph.tsx: the zoom and fit buttons' labels. Only the graph page uses it.app/knowledge-graph/skills/page.tsx:app/memory/page.tsx:components/knowledge-folders.tsx: the folder tree and folder editor shared by skills and memory, including the delete confirmation and the role limit.messages/{en,de,it}.json: new namespacesknowledgeGraph(80 keys),aiSkills(105),memory(64) andknowledgeFolders(32).source.toLowerCase(). The relationship status pill showed the rawstatus. The memory kind badge showed the rawkind.tbecametab,x,tagandname, so they don't shadow the translator.Left in English on purpose:
EnterpriseMemoryNoticeon the memory page (shown without an Enterprise licence), together withEnterpriseNoticeand the other billing and licensing components.skill_get, MCP, markdown, and "Skills Finder" (a product name).customer, because they're data examples, not UI text.Still open in #1271: the shared chrome is still English, and this PR doesn't change it:
Self-hosted vs Cloud: frontend only, with no backend, database or
ee/change.Translations
German and Italian aren't my native languages, so please review those strings. I kept the tone and terms from the earlier PRs:
Strings I'm least sure about:
Type
Testing
3 new tests in
tests/e2e/i18n.spec.ts, with a mocked graph (two entities, one relationship), two skills (one active with history, one merge proposal), knowledge folders and personal and company memory:de-DE: the graph page (header, layers, legend, the entity panel after clicking a node, the add entity form) and the AI Skills page (tabs, meta lines, "Replaces 2 active skills", history, the folder tree) render in German.it-IT: the memory page (access line, tabs, badges, the review tab, the folder tree, the workspace settings) renders in Italian.en-US: all three pages keep their exact English text, including the meta lines, "1 relationships", "4 example(s)" and the dates.The key-parity test from #1248 covers the new keys. I also checked that every German and Italian message parses and uses the same placeholders and tags as the English one.
packages/frontendnpm run lintmain, none new)packages/frontendnpx tsc --noEmit -p tsconfig.jsonpackages/frontendnpm run buildpackages/frontendnpm run test:e2eThe backend isn't touched, so I didn't rerun its suite.
Checklist
packages/frontend/AGENTS.mdandnext-env.d.tswere rewritten bynext devlocally and are left out, as AGENTS.md asks.Unrelated to this PR, but worth a look: after a clean
npm cionmain, the frontend dev server didn't start for me ("Incompatible React versions").package-lock.jsoninstallsreact19.3.1 at the root next toreact-dom19.2.7, whilepackages/frontend/node_modules/react-domis 19.3.1. The lockfile has looked like this since at least 874a536 (#1320). To run the tests locally I replaced the rootreact-domwith 19.3.1 by hand. This PR doesn't touch the lockfile.Related Issues
Last area of #1271 (Knowledge graph and memory). After this, every page area in the issue is translated; the shared chrome listed above is the only open part.