Repository navigation
Mask recipient addresses in the e-mail service logs - #1359
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Cloud backend log carries full recipient addresses at info level (
Trial-warn3 email sent to <address>, three lines in the 31 Oct check), and the same for every other transactional mail and its failure path. Addresses are personal data and have no place in the log.Changes
logger.log/warn/errorinsettings/email.service.tsthat named the recipient now printsmaskEmail(to)(ad***@example.com), reusing the helper fromauth/mcp-email-verification.ts. 19 lines, no behaviour change.Type
Testing
In packages/backend:
npx jest src/settings/email.service.spec.ts(18 passed),npx eslinton the two files,npx tsc --noEmit -p tsconfig.json. Same in Cloud and self-hosted.Checklist
Related Issues
Daily check 2026-10-31, cloud.md candidate 7b.