Repository navigation
Sort Binance futures tickers with a null quoteVolume last - #1358
Merged
Merged
Conversation
helpcodeai
enabled auto-merge (squash)
October 31, 2026 08:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
binance_futures_get_24h_tickercall on Cloud (31 Oct, 04:55 UTC) loggedResponse mapping failed (Invalid type: unexpected type (null)), returning the raw response: a contract with no trades answersquoteVolume: nullandto_number(null)aborts the JMESPath sort, so the user got the raw 40 kB answer instead of the sorted shape.Changes
to_number(quoteVolume || '0')in the sort key: a null volume sorts last, the row keeps its original fields.quoteVolume: nullsorts last and keepsquoteVolume: null.Type
Testing
npx jest src/adapters/intl/binance.live.spec.tsin packages/backend: 40 passed, 5 live skipped.node scripts/validate-adapters.mjspasses;regenerate-catalog.mjschanges nothing. Same in Cloud and self-hosted (catalog adapter; installed connectors pick it up via Apply update).Checklist
Related Issues
Daily check 2026-10-31, cloud.md candidate 5.