Repository navigation
# A clean checkout can build Compression.NativeUI - #809
Merged
Merged
Conversation
Symptom (#514): on a clean clone, `dotnet build CompressionWorkbench.slnx` fails in Compression.NativeUI with CS0246 for RibbonFieldItem, RibbonSpinner, RibbonComboBox and VirtualFile, with or without -p:NativeFormsFromSource=false. Root cause: without a ../NativeForms checkout, build/NativeForms.props falls back to the published NativeForms packages, and no published version carries the ribbon field controls NativeUI uses - they exist only on NativeForms main at the commit pinned in build/NativeForms.ref. CI clones that commit with its own action; nothing told a local build to. Fix: - build/get-nativeforms.sh / .ps1 fetch the pinned commit into ../NativeForms (or a given directory) exactly as CI does; the CI action now calls the script, so there is one definition. - The package fallback announces itself at build time and names the script. - README and CONTRIBUTING list the step. - The package fallback moves to the newest published versions (NativeForms 1.0.0.245, Windows 1.0.0.70, Gtk 1.0.0.82), which at least carry VirtualFile; the ribbon controls still need the next NativeForms release. Verified: the script fetches 1e14385 into a fresh directory and NativeUI builds against it with 0 errors; the fallback build prints the notice. Closes #514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clean checkout now has a documented, scripted way to build
Compression.NativeUI.Why it failed
Without a sibling
../NativeFormscheckout the build falls back to the published NativeForms packages, and no published version contains the ribbon field controls (RibbonComboBox,RibbonSpinner,RibbonFieldItem) NativeUI uses — they exist only at the NativeForms commit pinned inbuild/NativeForms.ref, which CI clones itself.Changes
build/get-nativeforms.sh/build/get-nativeforms.ps1: fetch the pinned commit into../NativeForms(or a given directory) the way CI does; the CI action now calls the script.build/NativeForms.props: the package fallback prints a notice naming the script; fallback package versions raised to the newest published (fixesVirtualFile; the ribbon controls still need the next NativeForms release).Verification
Compression.NativeUIbuilds with 0 errors against it.Closes #514