Skip to content

Document that the agent masks credential values in its config and log reads - #745

Open
DavidCockerill wants to merge 8 commits into
mainfrom
david/3097-agent-credential-masking
Open

DavidCockerill wants to merge 8 commits into
mainfrom
david/3097-agent-credential-masking

Conversation

@DavidCockerill

@DavidCockerill DavidCockerill commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

📝 Summary

Documents Mask credential values in the agent's config and log reads and in its read_log results (HarperFast/harper#3412): when the built-in agent reads its config or logs scope, or calls read_log, the value of every credential-named key comes back as *s. The page now says which keys and forms are masked, how config files are parsed, what is refused, and what is not covered. The 5.4 release note gets an entry with rotation guidance for sessions recorded earlier.

Refs HarperFast/harper#3097 · Refs #674 · Feature PR: HarperFast/harper#3412

🔧 Changes

✅ Verification

  • Every claim checked against the harper#3412 code and tests: key pattern, YAML parse with escaped keys and aliases, key-only masking of a broken file, the 256 KiB and UTF-8 refusals, byte-for-byte masking in config files, read_log's refused filter and PEM refusal.
  • prettier --check passes on both files; the new anchor #masked-credential-values matches the heading the release note links.

🤖 Generated with Claude Code

🤖 Generated by Claude Opus 5.5 (Claude Code); posted via @DavidCockerill.

Related PRs: #727 overlaps (open; edits the same agent options and 5.4 Built-in Agent section), #717 overlaps (merged; this replaces its config-secrets sentence), 2 others independent

Review-Coverage: authored=claude; ran=gemini,codex; adjudicated=domain; blocked=muse(failed); declined=cursor-grok,cursor-composer,cursor-kimi,cursor-muse; rounds=2; full=1 @ ffb2f20

Review-Attention: skim ~2m (decisions: masking-docs-location, release-note-rotate-advice, mask-length-disclosure) @ ffb2f20

DavidCockerill and others added 7 commits October 21, 2026 10:36
… reads

Refs HarperFast/harper#3097
Refs #674

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e, and a key's items too

Refs HarperFast/harper#3097
Refs #674

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs HarperFast/harper#3097
Refs #674

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs HarperFast/harper#3097
Refs #674

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… large one is refused

Refs HarperFast/harper#3097
Refs #674

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ps, and how many stars a value gets

Refs HarperFast/harper#3097
Refs #674

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs HarperFast/harper#3097
Refs #674

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gemini-code-assist[bot]

This comment was marked as resolved.

@github-actions
github-actions Bot temporarily deployed to pr-745 October 21, 2026 17:43 Inactive
@github-actions

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-745

This preview will update automatically when you push new commits.

…ntence

Refs HarperFast/harper#3097
Refs #674

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

🚀 Preview Deployment

Your preview deployment is ready!

🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-745

This preview will update automatically when you push new commits.

@DavidCockerill
DavidCockerill marked this pull request as ready for review October 22, 2026 18:29
@DavidCockerill
DavidCockerill requested a review from a team as a code owner October 22, 2026 18:29

This branch was successfully deployed

1 active deployment
pr-745 — ffb2f204 Deployed Oct 21, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants