Repository navigation
Document that the agent masks credential values in its config and log reads - #745
Open
DavidCockerill wants to merge 8 commits into
Open
DavidCockerill wants to merge 8 commits into
DavidCockerill wants to merge 8 commits into
Conversation
… reads Refs HarperFast/harper#3097 Refs #674 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e, and a key's items too Refs HarperFast/harper#3097 Refs #674 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs HarperFast/harper#3097 Refs #674 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs HarperFast/harper#3097 Refs #674 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… large one is refused Refs HarperFast/harper#3097 Refs #674 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ps, and how many stars a value gets Refs HarperFast/harper#3097 Refs #674 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Refs HarperFast/harper#3097 Refs #674 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-745 This preview will update automatically when you push new commits. |
…ntence Refs HarperFast/harper#3097 Refs #674 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-745 This preview will update automatically when you push new commits. |
DavidCockerill
marked this pull request as ready for review
October 22, 2026 18:29
dawsontoth
approved these changes
Oct 23, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
Documents Mask credential values in the agent's config and log reads and in its read_log results (HarperFast/harper#3412): when the built-in agent reads its
configorlogsscope, or callsread_log, the value of every credential-named key comes back as*s. The page now says which keys and forms are masked, how config files are parsed, what is refused, and what is not covered. The 5.4 release note gets an entry with rotation guidance for sessions recorded earlier.Refs HarperFast/harper#3097 · Refs #674 · Feature PR: HarperFast/harper#3412
🔧 Changes
reference/configuration/options.md— a new Masked credential values section under the agent's filesystem scopes, and the old "the agent reads it" sentence about config secrets replaced: a widenedconfigScopenow refuses large or binary files such as database files and backups.release-notes/v5-lincoln/5.4.md— a Credential Values Are Masked in the Agent's Config and Log Reads entry under Built-in Agent.✅ Verification
read_log's refusedfilterand PEM refusal.prettier --checkpasses on both files; the new anchor#masked-credential-valuesmatches the heading the release note links.🤖 Generated with Claude Code
🤖 Generated by Claude Opus 5.5 (Claude Code); posted via @DavidCockerill.
Related PRs: #727 overlaps (open; edits the same agent options and 5.4 Built-in Agent section), #717 overlaps (merged; this replaces its config-secrets sentence), 2 others independent
Review-Coverage: authored=claude; ran=gemini,codex; adjudicated=domain; blocked=muse(failed); declined=cursor-grok,cursor-composer,cursor-kimi,cursor-muse; rounds=2; full=1 @ ffb2f20
Review-Attention: skim ~2m (decisions: masking-docs-location, release-note-rotate-advice, mask-length-disclosure) @ ffb2f20