Repository navigation
Document full-text paging and configurable search limits - #739
kylebernhardy wants to merge 48 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive documentation for the new Full-Text Paging feature (continuation paging) in version 5.4.0, including a new dedicated guide, configuration options, REST header details, and sidebar integration. The review feedback suggests improving the formatting and placement of the <VersionBadge> component across several files to avoid awkward usage in running prose, recommending plain text or standalone placement under headings instead.
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-739 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-739 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-739 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-739 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-739 This preview will update automatically when you push new commits. |
🚀 Preview DeploymentYour preview deployment is ready! 🔗 Preview URL: https://preview.harper-documentation.harperfabric.com/pr-739 This preview will update automatically when you push new commits. |
⊙ Problem
The earlier draft described a separate full-text continuation API. Fill full-text and autocomplete pages using Harper's existing paging now fills ordinary limit/offset pages and removes that API.
💡 Solution
Explain paging, limits and recovery in the existing references. There are no continuation functions, tokens, close operations or retained searches, and no separate paging page or sidebar entry. Each page runs a new query and can see later changes.
⚖️ Alternatives
Document native full-text search owns the broader declaration/query guide. The reconciliation qualifies its historical 100-record prefix limit as pre-v5.4 and gives both guides the same independent-page and work-budget semantics. The two branches merge cleanly and their combined documentation build passes; numeric defaults and restart requirements remain in the existing configuration references. The broader guide also removes unsupported filterFields declarations and consolidates its duplicate 5.3 release-note sections. Publish this reference-owner change before the broader guide. Only the broader guide carries a Depends-on marker, pointing here; no reciprocal marker is added.
🔧 Changes
✅ Verification
Production build passes and processes 410 documents; repository-wide formatting passes after the paging and configuration clarification. The clarification and nine defaults were checked against the final paging core commit, including the accepted-record window, replay work and explicit budget-error contract. Default values and request/runtime names were checked against core's defaultConfig, validation, policy resolver and native binding. Error statuses were checked against query error mapping; the table is explicitly common failures, with 413 / other 500 behavior described separately. Local anchors and the public v0.6.0 native-limits link were checked; the build alone is not claimed to validate every anchor.
Earlier core verification covered 101 focused tests and all 14 deployed HTTP tests on both Node 24.16 and CI Bun 1.4.3. Its runtime fixture separately verifies unchanged captured budgets across replacement workers after configuration changes. The HTTP tests alone are not claimed to prove that negative restart boundary.
Earlier coverage comprised 10 rounds, eight full, with Claude, Cursor Composer/Muse and completed domain adjudication. Native Gemini CLI supplemented that earlier state and raised no documentation defects. The current cumulative canonical coverage is 12 rounds, nine full, as recorded above and in the generated footer. The last planning review did not clear automatically: its concrete placement, error, audit and reservation findings were adopted as described above; a generic build-source checker and product-wide error redesign were deferred rather than claimed complete. Native Gemini is supplemental coverage, not a canonical Gemini receipt.
Verify maxHeaderSize defaults across Harper HTTP configuration references remains an unrelated accuracy question. No version4 docs or ambiguous console default were changed. The core companion is ready for review and its current head passes all active CI checks. This documentation head also passes CI; all three bot review threads are resolved, and no new actionable feedback was found. The paging overlap with the broader full-text guide has been reconciled locally; that PR still has older unresolved human review threads requiring its own closeout. Kyle authorized moving this PR out of Draft after readiness checks clear. Neither PR may be merged by this task.
Comment generated by kAIle (GPT-6)
Release target: main — reference documentation for v5.4 full-text paging and limits.
Related PRs: #691 overlaps (Document native full-text search, complementary full-text guide), 4 others independent
Complexity: medium
Review-Coverage: authored=codex; ran=cursor-composer,cursor-muse,claude; adjudicated=domain; declined=gemini,cursor-grok,cursor-kimi; rounds=12; full=9 @ df5264e
Review-Attention: skim ~2m (decisions: coordinated-publication, defaults-ownership, native-limits-ownership) @ df5264e