Repository navigation
ci: E2E jobs run on backend-only PRs again - #396
Merged
Merged
Conversation
Both E2E jobs need build-images, which needs frontend-unit. On a backend-only PR frontend-unit is skipped, build-images still runs through its !cancelled() && !failure() check, but GitHub skips every job below a skipped one in the needs chain unless the job's if has a status function. So since #368 every backend-only PR merged without E2E. The E2E jobs now check !cancelled() and build-images' result themselves.
HardMax71
enabled auto-merge (squash)
October 18, 2026 22:10
github-actions
Bot
added
documentation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
6 of 17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small bug found while checking #394's CI: on a PR that skips Frontend Unit Tests, CI skips both E2E jobs too, so every backend-only PR since #368 merged without E2E (#391, #392, #394, #395). A break showed up only on main. Of the last 40 PR runs that ran Backend Unit Tests, all 14 that skipped Frontend Unit Tests skipped Backend E2E as well, for example #394's run with
backend = true.Changes
Both E2E jobs need build-images, and build-images needs frontend-unit. Without a status function in the
if, a skip "applies to all jobs in the dependency chain from the point of failure or skip onwards", even though build-images itself ran. The E2E conditions now start with!cancelled() && needs.build-images.result == 'success', the way build-images already handles its skipped needs. cicd.md says why.Type of Change
Test Plan
cd backend && uv run pytest tests/unit)cd frontend && npm run test)docker compose exec -T backend sh -c 'uv sync --group test --no-dev --frozen --no-install-project --no-build && pytest tests/e2e')cd frontend && npm run test:e2e)./deploy.sh openapi, then./deploy.sh types), never edited by handValidation: actionlint passes. This PR changes ci.yml, so every filter is on and its own run can't show the skip; the next backend-only PR will.
Checklist
pre-commit run --all-filesand all checks passSummary by cubic
Restores E2E coverage on backend-only PRs. Skipping the frontend unit job previously cascaded down the
needschain and skipped both E2E jobs, even though build-images ran fine.Both E2E jobs now gate on
!cancelled() && needs.build-images.result == 'success'in their ownifconditions, matching how build-images already handles skipped needs.cicd.mdnow documents why the status function is required.Written for commit 91b055c. Summary will update on new commits.