Skip to content

consistent-frame: the review control plants a section that skips the shared render #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HackingGate merged 1 commit into from
Nov 4, 2026
Merged

consistent-frame: the review control plants a section that skips the shared render #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions policy/upheld.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,8 @@ misses = "Make the refusal src/guard/push.rs prints after a failed forge lookup

[[review.control]]
record = "consistent-frame"
catches = "Make `uphold check --help` print its options before its usage line, while every other subcommand's help prints usage first."
misses = "Add a `--json` option to `uphold check --help`, listed in the options section in the same place and order as on every other subcommand's help."
catches = "Make scripts/review.py write the `consistent-frame` section of REVIEW.md from a string of its own, with **Ask** above **Applies when**, while render() writes every other record's section with **Applies when** first."
misses = "Change render() in scripts/review.py so every record's section of REVIEW.md prints **Ask** above **Applies when**."

[[review.control]]
record = "conways-law"
Expand Down
4 changes: 2 additions & 2 deletions review-controls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
},
{
"record": "consistent-frame",
"catches": "Make `uphold check --help` print its options before its usage line, while every other subcommand's help prints usage first.",
"misses": "Add a `--json` option to `uphold check --help`, listed in the options section in the same place and order as on every other subcommand's help."
"catches": "Make scripts/review.py write the `consistent-frame` section of REVIEW.md from a string of its own, with **Ask** above **Applies when**, while render() writes every other record's section with **Applies when** first.",
"misses": "Change render() in scripts/review.py so every record's section of REVIEW.md prints **Ask** above **Applies when**."
},
{
"record": "conways-law",
Expand Down
Loading