Repository navigation
Maak alle niet-witte logopixels zwart - #45
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
De logo-uploader maakte lichte kleuren met een grijswaarde vanaf 128 wit. Daardoor verdwenen lichte onderdelen van het logo op de zwart-witbon.
Alleen pixels waarvan alle RGB-kanalen minstens 245 zijn blijven nu wit. Alle andere kleuren worden effen zwart, ook helder geel en lichte grijstinten. Transparantie blijft op een witte achtergrond verwerkt. De opgeslagen NV-logo-indeling en bestaande LOGO-afdrukopdracht blijven hetzelfde.
De regressietest controleert wit, bijna-wit, de drempelwaarde, lichtgrijs en verzadigde kleuren. make test en make lint controleren de wijziging. Het logo moet opnieuw met load_printer_logo.py --write worden geüpload om het bestaande printerlogo te vervangen.