Repository navigation
fix batch logs policy enum typing - #14638
Open
jungwonenjoyericl wants to merge 1 commit into
Open
jungwonenjoyericl wants to merge 1 commit into
jungwonenjoyericl wants to merge 1 commit into
Conversation
product-auto-label
Bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the create_container_job function in batch/create/create_with_container_no_mounting.py to explicitly wrap the CLOUD_LOGGING destination enum value in the batch_v1.LogsPolicy.Destination constructor. There are no review comments, so no additional feedback is provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #13302
Fixes the mypy type error for the Batch LogsPolicy.Destination.CLOUD_LOGGING enum by explicitly constructing a LogsPolicy.Destination(with value batch_v1.LogsPolicy.Destination.CLOUD_LOGGING : int) value before assigning it to job.logs_policy.destination.
Verified with:
mypy batch/create/create_with_container_no_mounting.pyResult:
Success: no issues found in 1 source fileChecklist
Testing
Compliance & Style
Post-Approval Actions