Repository navigation
Do not rescale a fixed-size subplot panel -J taken from history - #9307
Merged
Merged
Conversation
When a panel map is drawn with a fixed-size -J (e.g. -JQ8c) it is not rescaled to fit the panel, but later modules that take -J from the history (plot, legend, ...) still rescaled it, so they no longer lined up with the map. Remember this in the panel history (@n). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test measures positions and deletes its PostScript, but gmtest gives any script that spells out "gmt begin" a $ps to compare and fails when it is missing. Spell the start command via $start, as subplot_3d_fit.sh does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joa-quim
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a subplot panel, a map drawn with a fixed-size -J (e.g.
-JM15c) is not rescaled to the panel, as documented. But the next modules that take-Jfrom the history (plot, text, legend, ...) did rescale it, so they no longer lined up with the map.Tested with:
Both red circle should be on Lisbon, but on master it lands inland.
This also adds
test/subplot/fixedJoverlay.sh, which needs no baseline: it checks that a circle plotted with-JM15cand one plotted with-Jfrom history end up at the same place in the PostScript.🤖 Generated using Claude Opus 5.5.