Repository navigation
tests: Avoid piping one GMT module into another - #9305
Merged
Merged
Conversation
Two GMT processes in a pipe start together and share gmt.history: the first one rewrites it when it exits while the second one reads it, so the second one can find an empty history and fail with "Found no history for option -R". The rerun does not always save it: a test that fails all three ctest attempts leaves the job red. Split every pipe with two or more GMT modules into sequential steps through temporary files, as recommended in the gmt movie "Shell limitations" docs. Only the 21 scripts that failed at least two of the three attempts in a job during the last 175 CI runs are changed; the ones that always passed on the first rerun are left alone. Pipes with a single GMT module are kept. For each script the output files are unchanged. See #9301. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joa-quim
reviewed
Nov 18, 2026
joa-quim
left a comment
Member
There was a problem hiding this comment.
But all these changes it means we are no longer testing the piping mechanism. Not good either.
Member
Author
|
Not really. I only applied this to the tests that failed most often. Dozens of test scripts (81) still pipe one GMT module into another. That said, if you prefer, I can switch to option (3) from #9301, where the second module gets explicit -R/-J values instead of reading them from the history. |
Member
|
(3) would be better in principle but not all of them can be solved that way, so no need to bother. |
joa-quim
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits every pipe with two or more GMT modules into sequential steps through temporary files, so the second module can no longer read an empty
gmt.historyand fail with "Found no history for option -R".It covers the 21 scripts that failed at least two of the three ctest attempts in a job during the last 175 CI runs (Sep 23 – Nov 17); each one produces the same output files as before.
Closes #9301
🤖 Generated with Claude Code