Repository navigation
Fix platform-dependent geovector heads with +n - #9300
Merged
Merged
Conversation
…st the vector length After +n rescaling the head length equals the limit, so the test that skips the head was decided by floating-point noise (differing per platform). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The geovector head fix now draws two tiny heads (records 14 and 289) that were skipped due to round-off; the output is identical on Linux, macOS and Windows (CI run 41692804604). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joa-quim
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked into why
grdvector/met_uvfails on Linux and Windows.There were several ways to fix it; I chose comparing against
h_length_limit * (1.0 + GMT_CONV8_LIMIT)(both geovector functions in src/gmt_plot.c) because it makes what is drawn independent of the platform. The fix also affectspsxy/flowvectors, where two tiny heads that were skipped are now drawn, so I updated the baselines of both tests and removed the known-failure flags frommet_uv.Tested with: CI. met_uv and flowvectors pass on Linux, macOS and Windows against the new baselines, with identical PostScript on all three (run 43902481512).
Generated with Claude Code (Claude Sonnet 5.5; review by Claude Opus 5.5)