Repository navigation
Describe what each theme slot is used for, and stop theming the farming seeds as rocks - #1101
Merged
Merged
Conversation
…ng seeds as rocks Theme authors only had a short label to choose the asset of a slot, so some themes put a shovel or a candy cane in the gun of the FPS starters, bread and bowls in the crops, and small trees in the scattered grass. Each slot now has a description of what its objects do in the starters and what fits it. The seeds of the farming starters were mapped to the small rocks, so every theme showed a rock, a bone or a wheel when a seed was planted: they keep their own model. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wa8uKpYuQrYqGYnqGCsquj
Contributor
Preview the game(s) changed or added in this Pull RequestNo games are changed in this Pull Request. This is an automatic message displaying links to the games in this PR - double check the JSON in case of doubt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme authors only had a short label to choose the asset of a slot ("First person weapon", "First crop or food item", "Grass or bush"). So some themes put a shovel or a candy cane in the gun of the FPS starters, bread and a bowl in the crops, and small trees or an air conditioner in the scattered grass. GDevelopApp/GDevelop-assets#717 fixes those themes.
Slot descriptions
Each of the 44 slots of
theme-slots.jsongets adescription: what its objects do in the starters, and what fits it. For example:weapon.handheld: "The gun held in first-person view in the FPS starters: the player aims it with the crosshair and fires it, and its bullets hit what it points at. It must shoot: a pistol, rifle, shotgun, blaster, crossbow or bow. Never a melee weapon or a tool (sword, axe, shovel, candy cane)."crop.a: "The first crop of the farming starters: it grows from a seed planted in a dirt plot, and is picked up when grown. Something grown from the soil: a vegetable, fruit, pumpkin or mushroom. Not cooked food or an object. Different from crop.b."nature.grass: "Small vegetation scattered densely on the ground of the expanded starters, which the player walks through (it has no collision) [...]. Not a tree or an object."The descriptions were written from the objects each slot is mapped to in the starters. The theme documentation of the assets repository points to them (GDevelopApp/GDevelop-assets#717).
The README asks for a description when a slot is added, and to map an object only to a slot whose description fits what it does.
Farming seeds
The seeds of both farming starters (
Seed_Beet,Seed_Carrot) were mapped tonature.rock.small, so planting a seed showed a rock, a bone, a wheel, a sack or a computer, depending on the theme. They are now inignoredObjectsand keep their own model.Checks
jest(52 tests),tscandprettierpass. Every starter passescheckStarterThemeSlotswith the new mappings.🤖 Generated with Claude Code
https://claude.ai/code/session_01Wa8uKpYuQrYqGYnqGCsquj