Repository navigation
fix(flow-chat): dismiss stale ACP sessions on archive - #3807
Open
Raing5Days wants to merge 1 commit into
Open
Raing5Days wants to merge 1 commit into
Raing5Days wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A failed ACP startup can delete its provisional session after a catalog read has already displayed it. Archiving that stale entry then fails because its metadata is gone. After an archive failure, confirm that an untouched, empty ACP catalog projection is absent on its owning host before removing the projection. Preserve sessions with history, uncertain reads, concurrent changes, or device switches.
Fixes #3788
Type and Areas
Type: bug fix
Areas: Web UI session lifecycle
Motivation / Impact
A stale ACP session from a startup timeout can be removed through the existing archive action without restarting. The provisional entry can still appear briefly while startup is in progress.
Verification
node scripts/run-vitest.mjs run --maxWorkers=50% src/flow_chat/services/flow-chat-manager/SessionModule.test.ts --silent(fromsrc/web-ui): 94 passed. Covers local and simulated peer projections, missing and existing records, offline reads, concurrent updates, and surface changes.pnpm run type-check:web: passed after copying generated API types from the matching main checkout into this worktree.git diff --check: passed.pnpm run check:web: failed in the unrelated MiniApp generated-artifact checks forchat-style-classes.jsandtheme.cssin this Windows checkout.Reviewer Notes
No native UI interaction or live remote workspace, Remote Control, Peer Device, or Detached Dispatch scenario was exercised.
Checklist