Skip to content

perf(scene-bar): memoize tabItems compilation to prevent redundant tab allocations #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Raing5Days wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(scene-bar): memoize tabItems compilation to prevent redundant tab allocations #3799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 45 additions & 43 deletions src/web-ui/src/app/components/SceneBar/SceneBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,51 +250,53 @@ const SceneBar: React.FC<SceneBarProps> = ({
};

// Each tab names its device through the label that opens its group.
let groupLabel: string | undefined;
const tabItems = shownTabs.reduce<TabGroupItem[]>((items, tab) => {
const group = groupStarts.get(tab.id);
if (group) groupLabel = `${groupLabelId}-${group.order}`;
const def = tabDefs.find(candidate => candidate.id === tab.id);
if (!def) return items;
const tabItems = useMemo<TabGroupItem[]>(() => {
let groupLabel: string | undefined;
return shownTabs.reduce<TabGroupItem[]>((items, tab) => {
const group = groupStarts.get(tab.id);
if (group) groupLabel = `${groupLabelId}-${group.order}`;
const def = tabDefs.find(candidate => candidate.id === tab.id);
if (!def) return items;

const translatedLabel = def.labelKey ? t(def.labelKey) : def.label;
const sessionLabel = sessionLabels[tab.id];
const displayLabel = sessionLabel?.title || translatedLabel;
const closeLabel = t('sceneBar.closeTab', { label: sessionLabel?.number ? `${displayLabel} ${sessionLabel.number}` : displayLabel });
const closable = isSceneTabClosable(def);
const translatedLabel = def.labelKey ? t(def.labelKey) : def.label;
const sessionLabel = sessionLabels[tab.id];
const displayLabel = sessionLabel?.title || translatedLabel;
const closeLabel = t('sceneBar.closeTab', { label: sessionLabel?.number ? `${displayLabel} ${sessionLabel.number}` : displayLabel });
const closable = isSceneTabClosable(def);

items.push({
value: tab.id,
label: displayLabel,
tabProps: groupLabel ? { 'aria-describedby': groupLabel } : undefined,
labelSuffix: sessionLabel?.number || tab.pinned || (tab.contentId && (resources[tab.contentId]?.isDirty || resources[tab.contentId]?.fileMissing)) ? <>
{sessionLabel?.number && <SessionTitleNumber number={sessionLabel.number} />}
{tab.pinned && <Pin size={12} aria-label={tComponents('tabs.unpin')} />}
{tab.contentId && resources[tab.contentId]?.isDirty && <span aria-label={tComponents('tabs.unsaved')}>•</span>}
{tab.contentId && resources[tab.contentId]?.fileMissing && <CircleAlert size={12} aria-label={tComponents('tabs.fileDeleted')} />}
</> : undefined,
labelTransitionKey: tab.session?.sessionId,
// Keep the close hit target stationary between pointer down and up;
// shrinking it can retarget the click at the button edge (issue #2210).
endAction: closable ? (
<button
type="button"
aria-label={closeLabel}
data-motion="none"
data-scene-bar-part="closeTab"
data-scene-id={tab.id}
onClick={(event) => {
event.stopPropagation();
closeScene(tab.id);
}}
tabIndex={-1}
>
<Icon name="xmark" size="xs" aria-hidden="true" />
</button>
) : undefined,
});
return items;
}, []);
items.push({
value: tab.id,
label: displayLabel,
tabProps: groupLabel ? { 'aria-describedby': groupLabel } : undefined,
labelSuffix: sessionLabel?.number || tab.pinned || (tab.contentId && (resources[tab.contentId]?.isDirty || resources[tab.contentId]?.fileMissing)) ? <>
{sessionLabel?.number && <SessionTitleNumber number={sessionLabel.number} />}
{tab.pinned && <Pin size={12} aria-label={tComponents('tabs.unpin')} />}
{tab.contentId && resources[tab.contentId]?.isDirty && <span aria-label={tComponents('tabs.unsaved')}>•</span>}
{tab.contentId && resources[tab.contentId]?.fileMissing && <CircleAlert size={12} aria-label={tComponents('tabs.fileDeleted')} />}
</> : undefined,
labelTransitionKey: tab.session?.sessionId,
// Keep the close hit target stationary between pointer down and up;
// shrinking it can retarget the click at the button edge (issue #2210).
endAction: closable ? (
<button
type="button"
aria-label={closeLabel}
data-motion="none"
data-scene-bar-part="closeTab"
data-scene-id={tab.id}
onClick={(event) => {
event.stopPropagation();
closeScene(tab.id);
}}
tabIndex={-1}
>
<Icon name="xmark" size="xs" aria-hidden="true" />
</button>
) : undefined,
});
return items;
}, []);
}, [closeScene, groupLabelId, groupStarts, resources, sessionLabels, shownTabs, t, tComponents, tabDefs]);

return (
<div data-openbitfun-component="scene-bar" data-openbitfun-part="root"
Expand Down
Loading