Skip to content

ci: Document and gate direct-push alerts - #993

Merged
knoepfel merged 2 commits into
mainfrom
maintenance/per-fork-guardrail-control
Oct 19, 2026
Merged

knoepfel merged 2 commits into
mainfrom
maintenance/per-fork-guardrail-control

Conversation

@greenc-FNAL

@greenc-FNAL greenc-FNAL commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor
  • CI: Added documentation for the guardrail push-alert workflow and its repository-variable and Slack webhook configuration.
  • CI: The Slack alert job now runs only when GUARDRAIL_AUDIT_ALERT_ENABLED is set to 'true' and the actor is not dependabot[bot]. This makes alerts opt-in.

- Change the slack-alert job condition to check `vars.GUARDRAIL_AUDIT_ALERT_ENABLED == 'true'` instead of only excluding dependabot
- This enables the guardrail audit alert only when explicitly enabled via a repository variable
- The workflow now requires explicit opt-in per repository/fork to send Slack messages

BREAKING-CHANGE: Guardrail push alerts now require setting the GUARDRAIL_AUDIT_ALERT_ENABLED repository variable to 'true' to function
@coderabbitai

coderabbitai Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2ac98514-d0a8-4176-8a58-b9b7294c6a1f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 058eb979-8d4d-4c49-bf51-e5a3c0604548
📥 Commits

Reviewing files that changed from the base of the PR and between 79a588d and 3539553.

📒 Files selected for processing: 1
  • .github/workflows/guardrail-audit-alert.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout: 2
  • GitHub Check: Analyze actions with CodeQL
  • GitHub Check: clang-tidy-check
🧰 Additional context used
🪛 zizmor (1.30.1)
.github/workflows/guardrail-audit-alert.yaml

[warning] 13-45: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

🔇 Additional comments: 2
.github/workflows/guardrail-audit-alert.yaml: 2

1-5: LGTM!

Also applies to: 7-12

22-22: LGTM!

📝 Walkthrough

The workflow now documents its direct-push alert purpose and configuration. The alert job runs only when GUARDRAIL_AUDIT_ALERT_ENABLED equals 'true' and the actor is not dependabot[bot].

Changes: Guardrail audit alert

Layer / File(s) Summary
Document and gate the alert job
.github/workflows/guardrail-audit-alert.yaml
A comment block describes the workflow purpose and configuration. The job condition now checks the enablement variable and retains the dependabot[bot] exclusion.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 35395

Slack alerts now require the intended opt-in variable to be set to true. The documented punctuation typo cannot create the alleged misconfiguration, leaving no actionable merge risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title clearly and concisely describes the workflow documentation and the new gate for direct-push Slack alerts.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot changed the title @coderabbitai ci: Document and gate direct-push alerts Oct 19, 2026
@knoepfel
knoepfel merged commit a9136d3 into main Oct 19, 2026
38 checks passed
@knoepfel
knoepfel deleted the maintenance/per-fork-guardrail-control branch October 19, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants