Skip to content

fix: forbid multi-layer unfolds for now - #961

Merged
marcpaterno merged 1 commit into
Framework-R-D:release/v0.4from
knoepfel:forbid-multilayer-unfold
Oct 8, 2026
Merged

marcpaterno merged 1 commit into
Framework-R-D:release/v0.4from
knoepfel:forbid-multilayer-unfold

Conversation

@knoepfel

@knoepfel knoepfel commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Issue #955 describes a case where Phlex is unable to process a workflow with multiple inputs (with different layers) presented to an unfold. The proposed solution is presented in PR #956, which will be included as part of Phlex v0.5.

This PR disables multiple inputs to unfolds where the inputs correspond to differently-named layers.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4a37c3ca-7239-4465-a863-33e87492a6b5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@               Coverage Diff                @@
##           release/v0.4     #961      +/-   ##
================================================
- Coverage         86.05%   86.00%   -0.05%     
================================================
  Files               184      184              
  Lines              8549     8555       +6     
  Branches           1027     1028       +1     
================================================
+ Hits               7357     7358       +1     
- Misses              943      946       +3     
- Partials            249      251       +2     
Flag Coverage Δ
scripts 80.45% <ø> (ø)
unittests 88.25% <100.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
phlex/core/declared_unfold.cpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae084f4...b196033. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcpaterno
marcpaterno merged commit 5ea99ee into Framework-R-D:release/v0.4 Oct 8, 2026
40 checks passed
@knoepfel
knoepfel deleted the forbid-multilayer-unfold branch October 8, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants