Repository navigation
Add merge_group trigger to CI workflows for merge queue readiness - #1015
Draft
greenc-FNAL with Copilot wants to merge 2 commits into
Draft
greenc-FNAL with Copilot wants to merge 2 commits into
greenc-FNAL with Copilot wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 4
Please check the settings in the CodeRabbit UI or the
|
Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enable merge queue feature for Phlex repository
Add Oct 26, 2026
merge_group trigger to CI workflows for merge queue readiness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phlex wants to enable GitHub merge queues. For that, the required CI checks must also run on
merge_groupevents, which they currently don't.Triggers
merge_group:to the eight*-checkworkflows (actionlint, clang-format, cmake-format, header-guards, jsonnet-format, markdown, python, yaml),cmake-build,coverageandcodeql-analysis.GITHUB_SHA, which is the queue's merge commit, so no changes are needed in theactions/*repos.Relevance gating
.beforein the event payload.merge_grouppayloads have no.before, so I didn't rely on detection there.merge_groupis now treated likeworkflow_dispatch: the jobs always run, so a queue run is never reported as passing without having run.cmake-build-skippednotice job is also suppressed onmerge_group.Not changed
clang-tidy-check: it isn't enforced, and its PR-comment and full-branch logic would need separate handling formerge_group.pushtomainstill triggerscmake-build. After this change that run repeats the queue run.Follow-up for repo admins
mainbranch ruleset.