Skip to content

Add merge_group trigger to CI workflows for merge queue readiness - #1015

Draft
greenc-FNAL with Copilot wants to merge 2 commits into
mainfrom
copilot/phlex-merge-queue-readiness
Draft

greenc-FNAL with Copilot wants to merge 2 commits into
mainfrom
copilot/phlex-merge-queue-readiness

Conversation

Copilot AI commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Phlex wants to enable GitHub merge queues. For that, the required CI checks must also run on merge_group events, which they currently don't.

  • Triggers

    • Added merge_group: to the eight *-check workflows (actionlint, clang-format, cmake-format, header-guards, jsonnet-format, markdown, python, yaml), cmake-build, coverage and codeql-analysis.
    • The shared setup actions already resolve the ref to GITHUB_SHA, which is the queue's merge commit, so no changes are needed in the actions/* repos.
  • Relevance gating

    • Change detection takes its base commit from .before in the event payload. merge_group payloads have no .before, so I didn't rely on detection there.
    • merge_group is now treated like workflow_dispatch: the jobs always run, so a queue run is never reported as passing without having run.
    • The cmake-build-skipped notice job is also suppressed on merge_group.
if: >
  always() && (
    github.event_name == 'workflow_dispatch' || github.event_name == 'merge_group' ||
    inputs.skip-relevance-check || needs.setup.outputs.has_changes == 'true'
  )

Not changed

  • clang-tidy-check: it isn't enforced, and its PR-comment and full-branch logic would need separate handling for merge_group.
  • push to main still triggers cmake-build. After this change that run repeats the queue run.

Follow-up for repo admins

  • Enable "Require merge queue" in the main branch ruleset.
  • Make sure the required status checks in that ruleset are the ones listed above.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 4
  • wip
  • draft
  • do not merge
  • dnm

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7cea1712-e26a-408a-ba7e-a6e5e030dd57

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI linked an issue Oct 26, 2026 that may be closed by this pull request
Co-authored-by: greenc-FNAL <2372949+greenc-FNAL@users.noreply.github.com>
Copilot AI changed the title [WIP] Enable merge queue feature for Phlex repository Add merge_group trigger to CI workflows for merge queue readiness Oct 26, 2026
Copilot AI requested a review from greenc-FNAL October 26, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Phlex repository group-merge readiness.

2 participants