Repository navigation
fix(recognize): default WASM asset URLs so webpack consumers can resolve them - #876
eugeniobet-ping wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 9211b48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
|
View your CI Pipeline Execution ↗ for commit 9211b48
💡 With Ultracache enabled, Nx Cloud learns each task's file inputs in CI and uses them on later runs. Turn on Ultracache in workspace settings ↗ · Read docs ↗ ☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud has identified a possible root cause for your failed CI:
We looked at the failing journey-suites login e2e, which timed out waiting 60000ms for config.webServer to start. Our changes only touch default WASM URLs in @forgerock/recognize, and nothing in the error points to that code, so we don't see a code fix to suggest. A rerun would show whether the timeout repeats.
No code changes were suggested for this issue.
Trigger a rerun:
View detailed reasoning on Nx Cloud ↗
🎓 Learn more about Self-Healing CI on nx.dev
The DaVinci server sends the operation ID as operationId in webSDKOptions, but the web component property (and our config option) is operationID, so a server option spread into the config was silently ignored. Accept both spellings in RecognizeWebComponentConfiguration and apply them in setAttributes; operationID wins when both are set. Fold the note into this PR's changeset and raise it from patch to minor, since the release now carries a new accepted option next to the WASM URL defaults.
@forgerock/davinci-client
@forgerock/device-client
@forgerock/journey-client
@forgerock/oidc-client
@forgerock/protect
@forgerock/recognize
@forgerock/sdk-types
@forgerock/sdk-utilities
@forgerock/iframe-manager
@forgerock/sdk-logger
@forgerock/sdk-oidc
@forgerock/sdk-request-middleware
@forgerock/storage
commit: |
|
Deployed 25d2961 to https://ForgeRock.github.io/ping-javascript-sdk/pr-876/25d296105020869be6d8afb738b26b94362edca7 branch gh-pages in ForgeRock/ping-javascript-sdk |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #876 +/- ##
===========================================
+ Coverage 18.07% 96.29% +78.22%
===========================================
Files 155 1 -154
Lines 24398 81 -24317
Branches 1203 17 -1186
===========================================
- Hits 4410 78 -4332
+ Misses 19988 3 -19985 🚀 New features to boost your workflow:
|
Interface Mapping Out of DateThe Drift reportTo fix, run: pnpm mapping:generateThen commit the updated |
📦 Bundle Size Analysis📦 Bundle Size Analysis🆕 New Packages🆕 @forgerock/journey-client - 95.4 KB (new) 📊 Minor Changes📈 @forgerock/recognize - 5606.0 KB (+0.5 KB) ➖ No Changes➖ @forgerock/davinci-client - 59.8 KB 15 packages analyzed • Baseline from latest Legend🆕 New package ℹ️ How bundle sizes are calculated
🔄 Updated automatically on each push to this PR |
JIRA Ticket
Description