Repository navigation
Conversation
Added handling for Errno::ECONNRESET in daemon_controller. Signed-off-by: Camden Narzt <6243207+CamJN@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added handling for
Errno::ECONNRESET, while trying to stop a daemon.#connectalready treatsECONNRESETas "can't connect" (perALLOWED_CONNECT_EXCEPTIONSand the#connectdocs). Before this change,ping_socketwas an exception to the pattern.ping_socketalso runs whilestartwaits for the daemon to come up. The same reset there would previously have crashedstartinstead of letting it retry.Motivation:
DaemonController#stoptreats Nginx as stopped once its PID file is gone. Nginx deletes its PID file before it closes its listening sockets. Sostopcan return while the port is still accepting connections.As-is daemon_controller connects without blocking, and the connection lands in the listen backlog (
EINPROGRESS). Nginx then closes the listening socket, which resets any connection still waiting in the backlog. The secondconnect_nonblockraisesECONNRESET.