Repository navigation
chore(Typecheck): Fail CI on new frontend type errors - #8826
Draft
talissoncosta wants to merge 6 commits into
Draft
talissoncosta wants to merge 6 commits into
talissoncosta wants to merge 6 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore/lint-review-rules #8826 +/- ##
========================================================
Coverage 98.88% 98.88%
========================================================
Files 1683 1683
Lines 70275 70275
========================================================
Hits 69489 69489
Misses 786 786 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
talissoncosta
force-pushed
the
chore/typecheck-base
branch
from
October 21, 2026 16:21
bff1241 to
4ad18f7
Compare
talissoncosta
force-pushed
the
chore/typecheck-base
branch
from
October 21, 2026 17:09
4ad18f7 to
cbee098
Compare
talissoncosta
force-pushed
the
chore/typecheck-base
branch
from
October 21, 2026 17:09
a08a830 to
9efcd1f
Compare
talissoncosta
force-pushed
the
chore/typecheck-base
branch
from
October 22, 2026 08:22
4b9579d to
5f9ecfb
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… tsc-baseline Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
talissoncosta
force-pushed
the
chore/typecheck-base
branch
from
October 22, 2026 08:26
5f9ecfb to
1120c1b
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Contributes to #8832
Stacked on #8819.
The frontend isn't type checked in CI, and main has about 760 type errors. This adds a CI step using tsc-baseline:
.tsc-baseline.jsonrecords today's errors (stories,documentation/and.storybook/excluded).web/components/base/or in a file the PR changed. New errors elsewhere are printed but don't fail.npm run typecheck:baselineshrinks the baseline. Later fix PRs add their folder to the list in the CI step.Errors are matched by file and message, not line number, so moving code doesn't count as a new error. If
tscexits without reporting any errors (a crash), the step fails rather than passing on empty input.Before merging: rerun
npm run typecheck:baselineon the rebased branch, so errors that landed on main in the meantime are in the baseline.To bring
base/to zero:FocusMonitorandParameterizedRouteuseOutsideClickanduseOverflowVisibleCountaccept React 19 nullable refs. Type only, wider than before, so no caller changes:DropdownMenu,ButtonDropdown,InlineModal,UserAction,SegmentOverrideActions,FeatureAction,SegmentAction,AccountDropdown,OverflowNav,TabsHow did you test this code?
Ran the CI step locally against a fresh
npm ci:base/Bannerfailsbase/that the PR didn't change is reported but passestscrun that crashes without output fails the step