Repository navigation
Conversation
Most context value properties select names one after the other, such as `$.identity.identifier`, `$.environment.name` or `$.flags.<name>.enabled`. Each was looked up by running the compiled JSONPath query. Such properties are now looked up by walking the context by those names, as `jsonpath_rfc9535` selects names: from dicts only, swallowing a `KeyError`. Other queries still run. About 5x faster per lookup.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most context value properties select names one after the other, such as
$.identity.identifier,$.environment.nameor$.flags.<name>.enabled. Each lookup ran the compiled JSONPath query.Such properties are now detected once per property (the getter is already cached) and looked up by walking the context by those names. This mirrors how
jsonpath_rfc9535selects names: from dicts only, swallowing aKeyError, including one raised while resolving$.flags. Any other query (indices, wildcards, filters, descendants, multiple selectors) still runs as before. A test checks results against the query for both kinds of property.Effect: ~2.9 → ~0.6 µs per lookup. Identity evaluation with released SDKs, which keep one
$.identity.identifiersegment per set of identity overrides, is about 2× faster with 1,000 of them (5.0 → 2.4 ms).Part of a stack of local evaluation performance PRs; see #353 for the stack and combined results.
perf/allholds the whole stack for benchmarking.