Repository navigation
Conversation
The identity key was resolved again for every feature evaluated, though it is the same throughout an evaluation. It is now resolved once, by `evaluate_features` and by the dependency resolver, and passed to a single flag result helper. `get_flag_result_from_context` is kept, resolving the key itself.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The identity key was resolved again for every feature evaluated, though it is the same throughout an evaluation. It is now resolved once, by
evaluate_featuresand by the dependency resolver, and passed to a single flag result helper,_get_flag_result.get_flag_result_from_contextis kept, resolving the key itself, so there is still only one implementation building flag results.This is the identity key part of #296, rebased onto the current evaluator (variant keys,
STATIC/DEFAULTreasons, dependent flags) without duplicating the flag result logic.Effect: full evaluations 8–17% faster (environment and identity); single-feature evaluation unchanged.
Part of a stack of local evaluation performance PRs; see #353 for the stack and combined results.
perf/allholds the whole stack for benchmarking.