Repository navigation
deps: update dependency setuptools to v84 [security] - #282
Open
renovate[bot] wants to merge 1 commit into
Open
renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
=======================================
Coverage 97.66% 97.66%
=======================================
Files 110 110
Lines 4963 4963
=======================================
Hits 4847 4847
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
>=83.0.0, <83.1.0→>=84.1.0, <84.2.0setuptools: Windows path escape via namespace_packages.txt during legacy wheel installation Description
GHSA-xmj3-9gf7-h52w
More information
Details
Summary
On Windows, attacker-controlled content in a wheel's
.dist-info/namespace_packages.txtcan cause setuptools' legacy wheelinstallation path to create an
__init__.pyoutside the requesteddestination_eggdir.The attacker can influence the destination path, but not the contents of
the created file.
Details
Tested setuptools commit:
6ead555c5fb29bc57fe6105b1bffc163f56fd558Relevant source:
setuptools/wheel.pySHA-256:
359b7e0d5dd8c3135653abe08a8ed5dc0352eadfd7df22cb5e2b5303b7c3cafdThe relevant call path is:
Wheel(wheel_path).install_as_egg(destination)→
_install_as_egg→
_convert_metadata→
_fix_namespace_packagesA wheel can provide attacker-controlled content in:
<distribution>.dist-info/namespace_packages.txtThe namespace value is eventually used approximately as:
A synthetic wheel was created containing:
demo_pkg-1.0.dist-info/namespace_packages.txtwhose content was the absolute path of:
sandbox\outsideThe real acquired setuptools implementation was then invoked:
The operation completed without exception.
Expected metadata was created under:
sandbox\destination\EGG-INFObut setuptools also created:
sandbox\outside\__init__.pyThe file did not exist before execution.
Its contents were:
The unrelated canary remained byte-identical.
The sandbox was deleted after recording the evidence.