Repository navigation
Conversation
cincuranet
reviewed
Oct 9, 2026
cincuranet
left a comment
cincuranet
left a comment
Member
There was a problem hiding this comment.
Regarding the obsoletion of PacketSize, I don't think we should put the attribute there. It is still valid setting for socket.
- Add new 'BlobSegmentSize' connection string property (range 512-65535 bytes) replacing the blob-specific role of PacketSize - Deprecate PacketSize on FbConnectionStringBuilder and FbConnection (use BlobSegmentSize instead) - Raise wire protocol blob segment limit from 32767 to 65535 bytes in GdsBlob, XdrReaderWriter (WriteBlobBuffer) and the native IFbClient interface (isc_get_segment / isc_put_segment now take unsigned shorts) - Plumb BlobSegmentSize through the full stack: ConnectionString -> GdsConnection / FesDatabase -> DatabaseBase -> BlobBase._segmentSize - Add tests for: connection string parsing/synonyms/validation, FbConnectionStringBuilder getter/setter, and blob read/write with BlobSegmentSize=65535 Fixes FirebirdSQL#1197
- Keep PacketSize as a regular (non-obsolete) setting: it still sizes the socket send/receive buffers of the managed client. - Remove the now-unused DatabaseBase.PacketSize (and the packetSize parameter of FesDatabase); GdsConnection is its only consumer. - Tests: follow the file's `const string ConnectionString` naming, drop the redundant BlobSegmentSizeValidationMaxBoundary test and fold its Validate() check into BlobSegmentSizeParsing.
fdcastel
force-pushed
the
fix-issue-1197
branch
from
November 7, 2026 13:22
1172b33 to
9f9cb4f
Compare
Member
Author
|
Regarding Also rebased onto current master; the review changes are in a separate commit (9f9cb4f) for easier re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1197.
Summary
This PR implements support for blob segment sizes up to 65535 bytes (64 KiB − 1), as supported by Firebird since version 2.1 (and fully reliable in Firebird 3.0+).
Changes
New
BlobSegmentSizeconnection string propertyBlobSegmentSizeis a new connection string key (synonym:blobsegmentsize) that controls the segment size used when reading/writing blobs.PacketSizedefault, so default behavior is unchanged).FbConnectionStringBuilder.BlobSegmentSizeandFbConnection.BlobSegmentSize.PacketSizeis unchangedPacketSizekeeps its meaning: it sizes the socket send/receive buffers of the managed client. It is just no longer (ab)used as the blob segment size.DatabaseBase.PacketSizewas unused once blobs readBlobSegmentSize, so it was removed (together with thepacketSizeparameter ofFesDatabase).GdsConnection.PacketSizeremains, as the only consumer.Raised wire protocol limits
GdsBlob.GetSegment(all 4 variants): cap changed fromshort.MaxValue - 12(32755) toushort.MaxValue(65535).XdrReaderWriter.WriteBlobBuffer: guard changed fromshort.MaxValuetoushort.MaxValue.IFbClient.isc_get_segment/isc_put_segment: parameter types changed fromshort/ref shorttoushort/ref ushort, matching the Firebird C API's actualunsigned shorttypes.FesBlobupdated accordingly.Stack plumbing
BlobSegmentSizeflows through the full stack:Tests
ConnectionStringTests: 6 new tests (default, parsing, synonym, validation boundaries).FbConnectionStringBuilderTests: 3 new tests (default, setter, getter).FbBlobTests: 2 new integration tests exercising blob read/write withBlobSegmentSize = 65535.