Repository navigation
fix: migrate Synapse dataset receipt API - #228
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the receipt API compatibility update.
No open issues 🎉
What changed in this PR
Updates the Synapse end-to-end dataset creation scenario for the new receipt API while preserving compatibility with released packages that use statusUrl.
Changes:
- Passes the Synapse client and complete creation result to
waitForCreateDataSet. - Keeps options in a separate variable to avoid excess-property errors with older types.
- Documents when the compatibility workaround can be removed.
| File | Description |
|---|---|
scenarios/synapse-e2e/create-dataset.ts |
Updates receipt-wait options to support both Synapse API versions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
A scout scan found no other consumers affected by the related receipt API changes. This does not fix the separate null-round polling failure tracked in FilOzone/synapse-sdk#1094.
Verification