Skip to content

fix: migrate Synapse dataset receipt API - #228

Merged
Kubuxu merged 1 commit into
mainfrom
fix/synapse-receipt-api
Nov 10, 2026
Merged

Kubuxu merged 1 commit into
mainfrom
fix/synapse-receipt-api

Conversation

@Kubuxu

@Kubuxu Kubuxu commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Pass the Synapse client and complete createDataSet result to waitForCreateDataSet, supplying the new receipt API with txHash and extraData.
  • Preserve compatibility with released Synapse packages that still consume statusUrl; keep options separate to avoid excess-property errors with their types.
  • Document when the compatibility accommodation can be removed.

A scout scan found no other consumers affected by the related receipt API changes. This does not fix the separate null-round polling failure tracked in FilOzone/synapse-sdk#1094.

Verification

  • All Synapse TypeScript scenarios passed strict type-checking against SDK 2.0.2 / Core 0.10.3 and frontier SDK/Core c937823, with viem 2.57.17 and Node 24.
  • Did not run foc-devnet or start a devnet.

@Kubuxu
Kubuxu requested review from beck-8 and rvagg as code owners November 10, 2026 14:24
Copilot AI balanced review requested due to automatic review settings November 10, 2026 14:24
@FilOzzy FilOzzy added this to FOC Nov 10, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Nov 10, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the receipt API compatibility update.

No open issues 🎉

What changed in this PR

Updates the Synapse end-to-end dataset creation scenario for the new receipt API while preserving compatibility with released packages that use statusUrl.

Changes:

  • Passes the Synapse client and complete creation result to waitForCreateDataSet.
  • Keeps options in a separate variable to avoid excess-property errors with older types.
  • Documents when the compatibility workaround can be removed.
File Description
scenarios/​synapse-e2e/​create-dataset.ts Updates receipt-wait options to support both Synapse API versions.

Review effort: Balanced

@Kubuxu
Kubuxu merged commit d4f8547 into main Nov 10, 2026
5 checks passed
@Kubuxu
Kubuxu deleted the fix/synapse-receipt-api branch November 10, 2026 14:27
@github-project-automation github-project-automation Bot moved this from 📌 Triage to 🎉 Done in FOC Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

2 participants