Repository navigation
Fix non-contiguous node tags in the Gmsh reader (#96) - #98
Merged
Merged
Conversation
nikoscham
commented
Oct 28, 2026
nikoscham
commented
Member
- Gmsh reader: when node tags have gaps (max tag > number of nodes), map each tag to a compact 1-based index and remap element and boundary node references; meshes with contiguous tags are read as before
- Previously each gap added a disconnected node with an all-zero matrix row, so Jacobi returned NaN and the LU solver failed
- Tests: add gmshReader unit test (test meshes copied with gaps in their node tags give the same nodes, connectivity and solution)
- Gmsh reader: when node tags have gaps (max tag > number of nodes), map each tag to a compact 1-based index and remap element and boundary node references; meshes with contiguous tags are read as before - Previously each gap added a disconnected node with an all-zero matrix row, so Jacobi returned NaN and the LU solver failed - Tests: add gmshReader unit test (test meshes copied with gaps in their node tags give the same nodes, connectivity and solution)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.