Repository navigation
Feature/triangular elements support - #97
Merged
Merged
Conversation
…Simulation" across all relevant files
- Gmsh reader: accept 6-node triangles; map Gmsh triangles to FEAScript numbering (bottom to top, then left to right, as for quads) - Triangle support (linear and quadratic) in heat conduction, front propagation and creeping flow (P2-P1 Taylor-Hood), all boundary conditions, the frontal solver, and Plotly/VTK plotting - Frontal solver: keep assembling until a node is fully summed (unstructured meshes) - Front propagation: count continuation steps with an integer, scale the minimum viscous term with element size, stop and report on non-convergence - Fix 1D quadratic frontal Dirichlet side map, exact (ksi, eta) for distorted quads in plotting, 1D front propagation missing errorLog import - Remove dead code (unused imports/variables, 8-node VTK cell branch, printVersionInformation, unused heatTransferCoefficient option) - Tests: shared Gmsh meshes (rect.geo, linear/quadratic quads and triangles), regression tests for all models, element types, orders and solver methods, analytical Couette and planar front tests, 2D element and plot interpolation unit tests; logo in every test README
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add triangular element support across models, solvers and plotting
numbering (bottom to top, then left to right, as for quads)
propagation and creeping flow (P2-P1 Taylor-Hood), all boundary
conditions, the frontal solver, and Plotly/VTK plotting
(unstructured meshes)
minimum viscous term with element size, stop and report on
non-convergence
distorted quads in plotting, 1D front propagation missing errorLog import
printVersionInformation, unused heatTransferCoefficient option)
triangles), regression tests for all models, element types, orders and
solver methods, analytical Couette and planar front tests, 2D element
and plot interpolation unit tests; logo in every test README