Repository navigation
Feature/universal frontal solver - #100
Merged
Merged
Conversation
Frontal solver (#77): - runFrontalSolver(assembleFront, meshData, boundaryConditionsHandler) no longer imports any physics model; model-specific parameters are bound into the assembler by the caller - Boundary condition classes implement a common frontal interface: imposeDirichletBoundaryConditionsFront and the optional imposeRobinBoundaryConditionsFront (returns null off Robin boundaries) - newtonRaphson takes assembleFront and boundaryConditionsHandler via context instead of importing frontPropagation - Frontal convection now applies every side of an element on the same boundary, matching the matrix assembly Restructure: - elements/: basis functions, numerical integration, isoparametric mapping, element geometry and initializeFEA (split from meshUtils) - physics/: models together with their boundary condition classes (was models/) - linalg/: sparse matrix and BLAS utilities (was numerics/) - io/: Gmsh reader, now including the Gmsh-to-FEAScript conversion previously in Mesh.parseMeshFromGmsh - solvers/index.js exports every solver except WebGPUComputeEngine Deduplicate boundary conditions: - Add getBoundarySides() to replace the repeated side-node tables - Thermal and generic BCs share one node loop for the matrix and frontal Dirichlet paths - Thermal convection uses one per-side computation for both paths (thermalBoundaryConditions.js 989 -> 425 lines) Add Prettier config matching the existing code style
Frontal solver (#77): - runFrontalSolver(assembleFront, meshData, boundaryConditionsHandler) no longer imports any physics model; model-specific parameters are bound into the assembler by the caller - Boundary condition classes implement a common frontal interface: imposeDirichletBoundaryConditionsFront and the optional imposeRobinBoundaryConditionsFront (returns null off Robin boundaries) - newtonRaphson takes assembleFront and boundaryConditionsHandler via context instead of importing frontPropagation - Frontal convection now applies every side of an element on the same boundary, matching the matrix assembly Restructure: - elements/: basis functions, numerical integration, isoparametric mapping, element geometry and initializeFEA (split from meshUtils) - physics/: models together with their boundary condition classes (was models/) - linalg/: sparse matrix and BLAS utilities (was numerics/) - io/: Gmsh reader, now including the Gmsh-to-FEAScript conversion previously in Mesh.parseMeshFromGmsh - solvers/index.js exports every solver except WebGPUComputeEngine Deduplicate boundary conditions: - Add getBoundarySides() to replace the repeated side-node tables - Thermal and generic BCs share one node loop for the matrix and frontal Dirichlet paths - Thermal convection uses one per-side computation for both paths (thermalBoundaryConditions.js 989 -> 425 lines) Add Prettier config matching the existing code style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouple the frontal solver from physics models and restructure src
Frontal solver (#77):
no longer imports any physics model; model-specific parameters are
bound into the assembler by the caller
imposeDirichletBoundaryConditionsFront and the optional
imposeRobinBoundaryConditionsFront (returns null off Robin boundaries)
context instead of importing frontPropagation
boundary, matching the matrix assembly
Restructure:
mapping, element geometry and initializeFEA (split from meshUtils)
(was models/)
previously in Mesh.parseMeshFromGmsh
Deduplicate boundary conditions:
frontal Dirichlet paths
(thermalBoundaryConditions.js 989 -> 425 lines)
Add Prettier config matching the existing code style