Repository navigation
Conversation
|
Sentinel 已审核此变更，未发现已核验问题，但发现需要人工确认的风险。 另有 8 个需要人工确认的风险；黄色 advisory 不阻塞合并，建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示： 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 bf338062f32b |
|
Sentinel 保留了 8 个尚未确认的审核候选。这些黄色条目不阻塞合并；红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时，可用行末 由 Sentinel 审核 · 目标提交 bf338062f32b |
Recheck dead-owner turns against native terminal status, keep delayed end handlers within their own session epoch, and only settle reuse evidence actually queued. Continue reading the completion handshake after stdout capture reaches its limit.
|
Sentinel 已审核此变更，未发现已核验问题，但发现需要人工确认的风险。 另有 15 个需要人工确认的风险；黄色 advisory 不阻塞合并，建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示： 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 78c65722098f |
|
Sentinel 保留了 15 个尚未确认的审核候选。这些黄色条目不阻塞合并；红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时，可用行末 由 Sentinel 审核 · 目标提交 78c65722098f |
Keep verified report payloads in the injection ledger after a local queue failure. Retry using the original check evidence and leave unverified injections out of delivery.
|
Sentinel 已审核此变更，未发现已核验问题，但发现需要人工确认的风险。 另有 11 个需要人工确认的风险；黄色 advisory 不阻塞合并，建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示： 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 c2f4ae537d21 |
|
Sentinel 保留了 11 个尚未确认的审核候选。这些黄色条目不阻塞合并；红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时，可用行末 由 Sentinel 审核 · 目标提交 c2f4ae537d21 |
Forward the supplied record after native terminal confirmation and handle a missing status reader. Give a dead owner a bounded grace for terminal metadata and omit any stale worktree. Isolated model declarations default to an empty environment.
|
Sentinel 已审核此变更，未发现已核验问题，但发现需要人工确认的风险。 另有 10 个需要人工确认的风险；黄色 advisory 不阻塞合并，建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示： 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 d255f1265811 |
|
Sentinel 保留了 10 个尚未确认的审核候选。这些黄色条目不阻塞合并；红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时，可用行末 由 Sentinel 审核 · 目标提交 d255f1265811 |
Keep the cross-shell calibration regression already landed upstream in EvoMap#55.
Require an explicit regular ZCode CLI bundle for background completion. Install through CLI plugin directories, and exercise the package without a Desktop installation.
imxyanua
changed the title
|
Sentinel 已审核此变更，未发现已核验问题，但发现需要人工确认的风险。 另有 17 个需要人工确认的风险；黄色 advisory 不阻塞合并，建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示： 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 29b7668f4494 |
|
Sentinel 保留了 17 个尚未确认的审核候选。这些黄色条目不阻塞合并；红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时，可用行末 由 Sentinel 审核 · 目标提交 29b7668f4494 |
Copying the index advances its mtime, which can make Git trust a cached stat entry for a same-size edit. Use the source index timestamp rounded down before adding untracked entries. A deterministic regression checks both diff parts and the untouched source index. (cherry picked from commit bbd7c68)
|
Sentinel 已审核此变更，未发现已核验问题，但发现需要人工确认的风险。 另有 9 个需要人工确认的风险；黄色 advisory 不阻塞合并，建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示： 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 b34de0bce67c |
|
Sentinel 保留了 9 个尚未确认的审核候选。这些黄色条目不阻塞合并；红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时，可用行末 由 Sentinel 审核 · 目标提交 b34de0bce67c |
Preserve the pending native-terminal deadline after its owner exits, pass the private configuration path to unbound environment callbacks, reject escaping scratch-file paths, and tolerate a vanished dead-owner state lock. Run the fixture Proxy independently of synchronous host work, preserve its request getter through the DSH wrapper, and track fixture-owned MiniMax workers for scoped teardown. Add regressions for the runtime contracts and native ZCode database discovery. Validation on this exact tree: full Linux tests on Node 22.23.4 and 26.13.0 each passed 908 with one Windows-only skip. Windows test:minimax passed 528 with ten platform skips and test:zcode passed 14 on both Node versions. Packaging all ten hosts passed on both platforms. Assertions, suite workloads, and existing deadlines remain unchanged.
|
Sentinel 已审核此变更，并发现 1 个已核验问题。 另有 9 个需要人工确认的风险；黄色 advisory 不阻塞合并，建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示： 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 ad1256e1f3f3 |
|
Sentinel 保留了 9 个尚未确认的审核候选。这些黄色条目不阻塞合并；红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时，可用行末 由 Sentinel 审核 · 目标提交 ad1256e1f3f3 |
![evomap-aiqa-bot[bot]](https://avatars.githubusercontent.com/u/278697308?s=60&v=4){kind=small}
| // Discard an oversized line through its newline without matching a partial suffix. | ||
| lines[0] = incompleteLine === null ? null : incompleteLine + lines[0]; | ||
| incompleteLine = lines.pop(); | ||
| if (incompleteLine?.length > OUTPUT_MAX_BYTES) incompleteLine = null; |
There was a problem hiding this comment.
握手匹配器抛错会逃逸 Promise 并可能终止宿主进程
🔴 严重程度：高（P1）
closeInputOn 在 stdout 的 EventEmitter 回调中直接执行，没有 try/catch，异常不会转化为 runProcess 的 Promise rejection，而会作为未捕获异常逃逸。这样 modelRunnerOf.complete() 的 finally 也无法可靠执行，临时目录和子进程可能遗留，整个插件宿主还可能退出。
Finding：finding_a775c9e8ba89aee8d871e1d8
A throwing closeInputOn callback escaped the stdout EventEmitter, which could terminate the host before model completion cleaned its private files. Keep the original error, stop the owned process tree, and normally finish when the child closes. Preserve the same error through the existing timeout and process-error paths, and do not start a Windows handshake process when tree termination is unavailable. Add regressions for child/grandchild termination, model error identity and private-file cleanup, and the missing Windows termination backend. The two exception tests failed uncaught before the fix. All five model-executor tests pass on Windows Node 22 and 26; each full Windows gate passes 531 common/MiniMax tests (10 platform skips), 14 ZCode tests, and packaging of all ten hosts. Existing assertions and deadlines are unchanged.
|
Sentinel 已审核此变更，未发现已核验问题，但发现需要人工确认的风险。 另有 17 个需要人工确认的风险；黄色 advisory 不阻塞合并，建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示： 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 4282859c1fe3 |
|
Sentinel 保留了 17 个尚未确认的审核候选。这些黄色条目不阻塞合并；红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时，可用行末 由 Sentinel 审核 · 目标提交 4282859c1fe3 |
An older turn waiting for its host record could consume a later turn's untagged check notes and edit baselines. Store evidence by the plugin epoch and turn counter, snapshot only the opened generation, and leave failed-reader claims recoverable with their original hashes. Keep ambiguous legacy files in their own namespace and bound abandoned evidence claims with the existing TTL; report-queue claims are unchanged. Carry prompt-opened and tool-recorded identities into monitor tasks instead of adopting the state current after asynchronous work. Pin that identity through polling and atomic turn close, separate generation lock keys, and prevent a delayed Git HEAD read from updating a replacement epoch. Regressions exercise real prompt/tool/turn flows, missing native turn IDs, same-ID epoch replacement, delayed worker startup, reader rejection and claim recovery, legacy namespace isolation, and evidence-only pruning. Joint driver/app/store/monitor/ZCode tests pass 140/140 on Windows Node 22 and 26. The complete Windows gates pass 542 common/MiniMax tests (10 platform skips), 14 ZCode tests and packaging of all ten hosts on both versions.
|
Sentinel 已审核此变更，未发现已核验问题，但发现需要人工确认的风险。 另有 10 个需要人工确认的风险；黄色 advisory 不阻塞合并，建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示： 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 4028a69f42ca |
|
Sentinel 保留了 10 个尚未确认的审核候选。这些黄色条目不阻塞合并；红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时，可用行末 由 Sentinel 审核 · 目标提交 4028a69f42ca |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
macOS temp folders are reached through the /var symlink, so the worker entry and the scratch workspace a child sees resolve to /private/var and the fixtures never matched them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sentinel 正在审核此变更，尚未形成最终结论。 大 PR 拆片审核中
开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 d23f10ededee |
|
Sentinel 已审核此变更，未发现已核验问题，但发现需要人工确认的风险。 另有 14 个需要人工确认的风险；黄色 advisory 不阻塞合并，建议开发 agent review advisory 评论并逐条确认。 审核覆盖提示： 开发 agent 查询详情： 调用 MCP 工具 由 Sentinel 审核 · 目标提交 bd90c21104d6 |
|
Sentinel 保留了 14 个尚未确认的审核候选。这些黄色条目不阻塞合并；红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
需要完整证据时，可用行末 由 Sentinel 审核 · 目标提交 bd90c21104d6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add local ZCode CLI support on Windows. Configure
ZCODE_CLI_PATHwith the absolute path to the trustedzcode.cjsbundle, and add the packed plugin folder through the CLI configuration. Desktop follow-up #57The CLI layer selects the explicitly configured runtime. It reuses the same adapter, hook and evidence code that the Desktop layer extends.
Evidence
plugins.dirsin a disposable profile, with six runnable hooks. This tested the loader and explicit runtime layout without a live model.Merge Danger
Two-way. The ZCode profile opts into native completion and captured model configuration. Tests exercise the shared process, report, and turn monitor paths. The Desktop layer adds its own marketplace and runtime discovery in #57.