Skip to content

Warn that Bazel's defines are transitive (for discussion) #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anakanemison wants to merge 1 commit into from
Open

Warn that Bazel's defines are transitive (for discussion) #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,10 +298,12 @@ recorded apart, as `test_configure_command`.
### Create initial BUILD.bazel files {#create-build-files}

Read `model.<frontend>.json`. For each production target emit a `cc_library` /
`cc_binary` with `srcs`, `hdrs`, `copts`, `defines`, `includes`, `deps`. Library
grouping need not match the reference (TU-set comparison is
grouping-agnostic), but keep **executable** names aligned or add a `target_map`
entry. Write `MODULE.bazel` as needed — before picking rulesets or pinning
`cc_binary` with `srcs`, `hdrs`, `copts`, `defines`, `includes`, `deps`. Bazel's
`defines` propagate to every dependent; a define the reference keeps private to
one target (CMake's `PRIVATE`, such as `<target>_EXPORTS`) belongs in
`local_defines`. Library grouping need not match the reference (TU-set
comparison is grouping-agnostic), but keep **executable** names aligned or add
a `target_map` entry. Write `MODULE.bazel` as needed — before picking rulesets or pinning
versions, read
[docs/BAZEL-RULES.md](docs/BAZEL-RULES.md) (which rulesets have been exercised
here, why some were hand-written instead, and why a version must be resolved
Expand Down
Loading