Repository navigation
Decide target_map renames in one place, and list renamed exclusions - #38
Open
anakanemison wants to merge 1 commit into
Open
anakanemison wants to merge 1 commit into
anakanemison wants to merge 1 commit into
Conversation
exclude_targets holds CMake names. The diff applies target_map before deciding participation, so a Bazel target mapped to an excluded CMake name is skipped. excluded_summary, which reports what was skipped and why, checked the raw Bazel label instead, so that target appeared nowhere in `excluded.bazel`: skipped, but not on the record. A new helper, _bazel_renames, returns each Bazel label with the name the diff compares it under (today, the target_map entries whose label exists), and is the one place that decision is made. diff_models renames the Bazel views with it and, as before, also applies every explicit target_map entry to dependency references (a map entry can align an external dependency that has no target node). excluded_summary checks exclusion on the renamed name while still listing the target under its Bazel label. The per-side summaries later in this series use the same helper, so they count exactly the targets the diff compares, and the automatic executable alignment extends it rather than deciding separately. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 23 of a stacked series (tracking issue: #35). Based on
U02-validate-bazel-args, the previous part: review and merge that first.Kind: fix. Lab proposal: (support for P3, P17).
What the migration runs showed
A Bazel target mapped to an excluded CMake name was skipped without being listed in
excluded.bazel.The change
exclude_targets holds CMake names. The diff applies target_map before
deciding participation, so a Bazel target mapped to an excluded CMake name
is skipped. excluded_summary, which reports what was skipped and why,
checked the raw Bazel label instead, so that target appeared nowhere in
excluded.bazel: skipped, but not on the record.A new helper, _bazel_renames, returns each Bazel label with the name the
diff compares it under (today, the target_map entries whose label exists),
and is the one place that decision is made. diff_models renames the Bazel
views with it and, as before, also applies every explicit target_map entry
to dependency references (a map entry can align an external dependency
that has no target node). excluded_summary checks exclusion on the renamed
name while still listing the target under its Bazel label. The per-side
summaries later in this series use the same helper, so they count exactly
the targets the diff compares, and the automatic executable alignment
extends it rather than deciding separately.
Testing
pytest tests/at this commit: 138 passed (130 onmain).🤖 Generated with Claude Code