Repository navigation
plugins/recover: fix missing comma in nodes_for_gossip array - #9631
Open
bhuvan-somisetty wants to merge 1 commit into
Open
bhuvan-somisetty wants to merge 1 commit into
bhuvan-somisetty wants to merge 1 commit into
Conversation
A missing comma at the end of the line for the nicehash-ln1 entry caused C string literal concatenation to merge the nicehash-ln1 and BLUEIRON addresses into a single invalid address string: "037659...195024b9a1...". This reduced the array count to 9 and broke connection attempts to both nodes during emergency recovery when entering recovery mode without active peers. Add the missing comma and add a test verifying all bootstrap node addresses. Changelog-Fixed: plugins/recover: fix missing comma in nodes_for_gossip array. Fixes: ElementsProject#9630 Signed-off-by: bhuvan-somisetty <somisettybhuvan5@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
plugins/recover.c,nodes_for_gossip[]contains a list of bootstrap node addresses used to sync gossip when entering emergency recovery mode without peers.On line 40, a missing comma at the end of the
nicehash-ln1entry caused C compiler string literal concatenation to merge thenicehash-ln1address and theBLUEIRON-v23.08.1address into a single invalid address string (037659...195024b9a1...). Consequently,ARRAY_SIZE(nodes_for_gossip)was 9 instead of 10, and connection attempts to both nodes failed.This PR adds the missing comma to
plugins/recover.cand adds a test intests/test_misc.pyvalidating that each bootstrap node entry innodes_for_gossipis a valid, distinct address.Fixes #9630.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:
tools/lightning-downgradeSigned-off-by: bhuvan-somisetty somisettybhuvan5@gmail.com