Repository navigation
ci: per-branch publish concurrency with gh-pages push retry - #35
Merged
Merged
Conversation
A single workflow-wide concurrency group dropped publishes: GitHub keeps only one pending run per group, so when the 2.4-2.11 conversions merged together, six of the eight runs were cancelled before they ran. Split the workflow into two jobs: - publish: one concurrency group per branch (a superseded pending run is harmless, since the newest push contains it). Branches build in parallel; if another branch updates gh-pages first, mike's push is rejected and the job rebuilds on the new tip and retries. - deploy: one group across all branches for the Cloudflare upload. It exports gh-pages when it starts, so whichever queued upload survives already includes every earlier publish. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
📖 Docs preview: https://pr-35-edgetx-lua-reference-guide.edgetx.workers.dev/2.12/ Built from 6ae4e47 as the |
pfeerick
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in per-branch publish concurrency with gh-pages push retry (#35), so this branch's copy matches every other branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in per-branch publish concurrency with gh-pages push retry (#35), so this branch's copy matches every other branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in per-branch publish concurrency with gh-pages push retry (#35), so this branch's copy matches every other branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in per-branch publish concurrency with gh-pages push retry (#35), so this branch's copy matches every other branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in per-branch publish concurrency with gh-pages push retry (#35), so this branch's copy matches every other branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in per-branch publish concurrency with gh-pages push retry (#35), so this branch's copy matches every other branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in per-branch publish concurrency with gh-pages push retry (#35), so this branch's copy matches every other branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in per-branch publish concurrency with gh-pages push retry (#35), so this branch's copy matches every other branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The publish workflow used one workflow-wide concurrency group. GitHub keeps at most one pending run per group and cancels older pending ones, even with
cancel-in-progress: false. When the 2.4–2.11 conversions (#23–#30) merged together, six of the eight publish runs were cancelled before they ran, and those versions weren't republished until I dispatched them by hand. This can happen any time three or more pushes land within about a minute.Fix
The workflow is now two jobs:
publishhas one concurrency group per branch (publish-versioned-docs-<branch>). Cancelling a superseded pending run on the same branch is harmless, because the newest push already contains it. Different branches build in parallel. If another branch pushes togh-pagesfirst, mike's push is rejected as non-fast-forward. The job then resets to the new tip, rebuilds, and retries, up to 5 attempts with backoff.deployhas one group shared across all branches, so Cloudflare uploads never overlap. It exportsgh-pageswhen the job starts. If several uploads are queued and GitHub keeps only the newest, that one already includes every earlier publish, so the last upload is always the newest tree.Testing
Simulated the race locally with a bare copy of
gh-pagesasorigin, plus a one-shotpre-pushhook that pushes a competing commit from another clone just before mike's push:mike deploy --pushfails withremote rejected … incorrect old value provided, and the job fails.bash -eo pipefail, like Actions): attempt 1 is rejected, attempt 2 rebuilds on top and succeeds. Both the competing commit and the new deploy are ongh-pages.Rollout
Every branch carries its own identical copy of this workflow. After this merges, the same file needs to go to
main(through #17) and toedgetx_2.4–edgetx_2.11. Until then, those branches keep the old single group and have no retry. A collision there shows up as a failed run, not a silently missing version.🤖 Generated with Claude Code