Repository navigation
Conversation
fix to use prepend rather than append fix comment for volume parameter example
This was referenced Oct 23, 2026
Member
|
Thanks for this, @arkarkark, and sorry it sat for so long. You were right on both counts: the language path is prepended, and the example uses volume 5. The docs have since moved from GitBook to MkDocs, so this PR no longer applies to the current tree. I've carried your fix over to the maintained versions, with you credited as co-author:
|
pfeerick
added a commit
that referenced
this pull request
Oct 23, 2026
A relative filename gets the current language's sound directory put in front of it, so the language is prepended, not appended. The first example passes volume 5 but its comment said 2. Patched the playFile entry in the committed API model to match the upstream luadoc fix (EdgeTX/edgetx#7936) and regenerated with `docs_pipeline.py build`. The only outputs that change are the playFile page, its review page and the LuaLS stubs. Supersedes #10. Co-authored-by: Alex K <arkarkark@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
pfeerick
added a commit
that referenced
this pull request
Oct 23, 2026
A relative filename gets the current language's sound directory put in front of it, so the language is prepended, not appended. The first example passes volume 5 but its comment said 2. Supersedes #10. Co-authored-by: Alex K <arkarkark@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix to use prepend rather than append
fix comment for volume parameter example