Repository navigation
Make Large Tx History card closable for good - #6283
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
Claude Code Review is paused for this repository because its GitHub organization is not linked to your Claude organization.
To turn it back on, one person needs both roles: owner of the GitHub organization (or the account owner, for a personal repository) and admin or owner of your Claude organization. If that is not you, pass this on to someone who is.
Open Organization settings, Git providers and click Link next to the GitHub organization's name. If it is not listed, click Enable GitHub integration or Connect your GitHub first, whichever the page shows.
New pull requests are then reviewed as before. To get a review on one that is already open, someone with write access can comment @claude review.
Tip: disable this comment in your organization's Code Review settings.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
AlertCardUi4 takes an optional onClose and passes it to EdgeCard, which draws the corner close button. The title row keeps clear of that button.
Rename the Large Wallet card to Large Tx History, shorten its copy, and show it only while the wallet syncs, animating out with the sync card. The card's close button hides it for good, for every wallet on the account: the close is saved to the account's local settings. Each close is written to the activity log, giving a record that the user saw the warning.
- edgeCardCloseButton: the corner close button EdgeCard renders when onClose is set
7a8f3fc to
42704a5
Compare
Description
Asana task
The Large Wallet card warns that a UTXO wallet with a long transaction history syncs slowly and shows a wrong balance until it finishes. It stayed on screen permanently, and users either ignored it or filed tickets. This PR:
largeTxHistoryCardDismissed) and survives new syncs, other wallets, and app restarts.Large Tx History card closed: <pluginId> <walletId>), which records that the user saw the warning.AlertCardUi4gains an optionalonClosethat passes through to the corner close button ofEdgeCard. No other warning card uses it.CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
none
Requirements
If you have made any visual changes to the GUI. Make sure you have:
Test evidence
7a8f3fctest: add testIDs to EdgeCard close button
2026-10-23
🪓 LARGE_UTXO_WALLET_TX_COUNT lowered from 100 to 0 so the small test wallets qualify, and the BTC/LTC sync card forced to render a placeholder line so the open sync is visible; both reverted
1. 🪓 card during sync
2. 🪓 closed during sync
3. 🪓 stays closed next sync
4. 🪓 stays closed other wallet
5. 🪓 stays closed after relaunch