Repository navigation
ECOM-64901 - add orderBy field's support to variations for GET requests only - #567
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change adds nullable, response-only orderBy support for fetched variations and includes contract and Gson coverage for populated, missing, and explicit null values.
No open issues 🎉
What changed in this PR
Adds support for deserializing the optional orderBy field on fetched product variations while keeping it nullable and read-only for update requests.
Changes:
- Adds nullable
orderBytoFetchedVariation. - Updates nullable-property and non-updatable DTO contract rules.
- Adds Gson tests for populated, missing, and explicit
nullvalues.
| File | Description |
|---|---|
src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/FetchedVariationRules.kt |
Allows nullable orderBy values in fetched variations. |
src/test/kotlin/com/ecwid/apiclient/v3/rule/NonUpdatablePropertyRules.kt |
Marks orderBy as read-only for variation updates. |
src/test/kotlin/com/ecwid/apiclient/v3/jsontransformer/gson/GsonTransformerTest.kt |
Verifies orderBy deserialization for present, missing, and null values. |
src/main/kotlin/com/ecwid/apiclient/v3/dto/variation/result/FetchedVariation.kt |
Adds the optional response-only orderBy property. |
Review effort: Lite
vlka597
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subj