Repository navigation
fix(phar): leave the packages' tests and features out of the phar - #1946
Merged
mrrobot47 merged 2 commits intoOct 12, 2026
Merged
Conversation
The ee-*.json step of make-phar.php reused the previous Finder, which still matched *.php, and added every PHP file below each *-command package: features/bootstrap of the released phars and, with the incremental engine, site-command's 60 PHPUnit test files. It now starts from a new Finder, and the build job fails when a package's tests/ or features/ is in the phar.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation correctly fixes the packaging issue; only a minor diagnostic wording issue remains.
1 open finding
What changed in this PR
Prevents package test and feature files from entering the Phar archive.
Changes:
- Uses a fresh Finder for package JSON files.
- Adds CI validation for excluded directories.
| File | Description |
|---|---|
utils/make-phar.php |
Resets Finder filters before collecting JSON files. |
.github/workflows/test_and_build.yml |
Verifies excluded package content is absent. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
utils/make-phar.phpreused the previousFinder(still matching*.php) for theee-*.jsonstep, so every PHP file below each*-commandpackage went into the phar, including the packages'features/andtests/directories. The step now uses a freshFinder, and CI gets a "Check phar contents" step that fails whenvendor/easyengine/*/(tests|features)/paths end up in the phar.Checked: the step fails on a phar built before the change and passes after it, and the new phar lost exactly those files.