Repository navigation
feat: add requirements.ephemeral_data_disk - #1461
Merged
Merged
Conversation
kvinwang
force-pushed
the
feat/ephemeral-data-disk
branch
from
October 22, 2026 01:53
68c9d6a to
3d429ee
Compare
Signed-off-by: Kevin Wang <wy721@qq.com>
Signed-off-by: Kevin Wang <wy721@qq.com>
kvinwang
force-pushed
the
feat/ephemeral-data-disk
branch
from
October 22, 2026 02:42
3d429ee to
01637c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some apps need every boot to start from a clean data disk, so that no state from an earlier boot (or a copy the host rolled back) is visible to app code. Right now the guest always reuses whatever filesystem it finds on the data disk.
Fix
Add an opt-in
requirements.ephemeral_data_diskfield (defaultfalse) toapp-compose.json.mount_data_diskskips detection and always initializes the disk: it runs a freshluksFormat(new random volume key, which makes the old ciphertext unreadable), clears stale ZFS labels, and creates the filesystem. This all happens before any app code runs.health_check,falseis omitted from the output, so compose hashes for existing apps do not change.The field sits under
requirements, so it needsmanifest_version: "3". Older guests reject it, so they fail closed instead of ignoring it.The VMM is deliberately left out. Replacing
hda.imgon the host would rule out a later option that keeps named volumes across boots.