Repository navigation
Conversation
`backend/Dockerfile` still installed mockery v3.7.2 while the Makefile, `Dockerfile.local` and `scripts/install-mockery.sh` (used by CI) are on v3.7.4, so the generated mocks depended on which build path was used. - Bump the `backend/Dockerfile` pin to v3.7.4. - Introduce `MOCKERY_VERSION` (default v3.7.4) and `MOCKERY ?= GOOS= GOARCH= CGO_ENABLED=0 go run github.com/vektra/mockery/v3@$(MOCKERY_VERSION)` in the Makefile; `make mock` and `make go-dep` use them. `make mock` thus no longer depends on whatever `mockery` is on the PATH (the CI builder image `mericodev/lake-builder:latest` ships mockery v2, which cannot read the v3 YAML configuration). GOOS/GOARCH are cleared so the tool is built for the host even when `backend/Dockerfile` cross-compiles `make all`. `MOCKERY=mockery make mock` keeps the old behaviour.
Owner
Author
|
Evidence done: 8/8 upstream workflows green on 6c9a7b9 (wave 9 + trigger). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway: wave 9 + a comment line in a .sh file so that unit-test and test-e2e run. Will be closed.