Repository navigation
Conversation
backend/mocks/ is git-ignored, but helpers/unithelper and 22 test files import five of its packages. On a fresh clone those import paths do not exist inside the main module, so go mod tidy tries to resolve them as external modules and fails with "no matching versions for query latest". This also keeps Dependabot's gomod updater from producing any update. Track one doc.go placeholder (package mocks, no code) in each imported mock package, so the paths resolve locally. The generated mocks stay git-ignored, and make mock now removes only the generated files instead of the whole directory. Add a step to the unit-test workflow that runs go mod tidy on the fresh checkout, before any mocks are generated, and fails on a diff. A new mock import without a placeholder, or an untidy go.mod, is caught there. Refs apache#9088
DoDiODev
force-pushed
the
pr/gomod-mock-placeholders
branch
from
September 28, 2026 11:04
a712067 to
cf96ac5
Compare
Owner
Author
|
CI verification done (9/9 green on cf96ac5). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-only CI verification for the upstream PR (refs apache#9088). Runs the unmodified upstream workflows against a copy of upstream/main. Will be closed after the run.